Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

bump etcd and flannel to the latest versions to get multiarch images for arm64 support #1179

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

pothos
Copy link
Contributor

@pothos pothos commented Aug 10, 2021

A number of kola tests fail because on arm64 we don't have etcd and flannel working due to using an image tag by default that isn't a multiarch image.

things to keep in mind:

  • etcd now defaults to v3 - I guess this is something we'd like to communicate for people using etcd shipped by Flatcar (we can also update the etcd-member.service to keep V2 support and let users doing the upgrade)
  • flannel and locksmith does not support etcd/v3: we need to start etcd with --enable-v2 + use ETCDCTL_API=2 (there is an on-going effort to port locksmith to v3: upgrade to etcd/client/v3 flatcar/locksmith#12)

How to use

The new image tags used here are multiarch images and it should work to pass the kola tests on arm64 with them.

Testing done

CI: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/3368/cldsv/
amd64: 🔵
arm64: 🔴 it only remains the kubeadm.* test to pass; which should be quite trivial to fix I hope (see: flatcar/Flatcar#474)

@tormath1
Copy link
Contributor

@pothos for the failing tests Error: unknown command "cluster-health" for "etcdctl", we can first start by prefixing the etcdctl command with ETCDCTL_API=2 in order to keep using V2 APIs.

Once merged, we can open an issue to track everything related to etcd/v3 upgrade with:

  • kola test update
  • locksmithctl update (already in progress)
  • ...

@tormath1 tormath1 marked this pull request as ready for review August 26, 2021 07:27
@tormath1 tormath1 requested a review from a team August 26, 2021 07:28
@pothos
Copy link
Contributor Author

pothos commented Aug 26, 2021

@tormath1 Should I squash and merge or do you want to do it?

@tormath1
Copy link
Contributor

@pothos feel free to do it :)

@pothos pothos merged commit 4439402 into main Aug 26, 2021
@pothos
Copy link
Contributor Author

pothos commented Aug 26, 2021

Thanks for taking over

@pothos pothos deleted the kai/etcd-flannel-multiarch branch August 26, 2021 08:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants