Allow disabling the usage of open compounds in sentences #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjozwik
force-pushed
the
2102-handle-open-compounds
branch
from
cf31304
to
12f0867
Compare
tjozwik
changed the title
There was a problem hiding this comment.
@tjozwik can we add test cases around new param that we are passing in sentence method? Apart from that PR looks good to me
|
@sudeeptarlekar tests cases added. |
|
@tjozwik can you please rebase branch with latest code, this will fix flaky failures. |
tjozwik
force-pushed
the
2102-handle-open-compounds
branch
from
390736f
to
9ade240
Compare
sudeeptarlekar
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
Looks good to me. I will leave further process to @psibi, @Zeragamba.
Zeragamba
approved these changes
Oct 10, 2020
|
Thanks! |
droznyk
pushed a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
…2109) * Allow disabling using open compounds in sentences * Create tests for sentences with open compounds
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
…er-ruby#2109)" This reverts commit 5cbb62e.
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
…er-ruby#2109)" This reverts commit 5cbb62e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected with: Issue #2102
Alternative solution fixing the same issue: #2108
Description
open_compounds_allowedthat allows to disable using open compounds ('words' containing additional spaces inside) inFaker::Hipster.sentenceandFaker::Books::Lovecraft.sentence. By default the usage of open compounds would be allowed,random_words_to_addparam type in comment regardingFaker::Hipster.sentencemethod.Additional info
faker.lovecraft.wordslist butFaker::Books::Lovecraft.wordshave a possibility of handling them, so it can be used after word list is updated,Faker::Lorembut bothFaker::Lorem.wordsdoesn't have a possibility to treat open compounds differently than normal words, and there is no open compounds onfaker.lorem.wordslist.