-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
word_count option for Faker::Hipster.sentence is not working #2102
Comments
Temporary solutionCurrently, you can use it with an additional explicit param 2.6.6 :039 > Faker::Hipster.sentence(word_count: 4, random_words_to_add: 0)
=> "Chillwave park gentrify sustainable." ContextThe same issue appears to exist in def sentence(legacy_word_count = NOT_GIVEN, legacy_supplemental = NOT_GIVEN, legacy_random_words_to_add = NOT_GIVEN, word_count: 4, supplemental: false, random_words_to_add: 6) Meanwhile, in def sentence(legacy_word_count = NOT_GIVEN, legacy_supplemental = NOT_GIVEN, legacy_random_words_to_add = NOT_GIVEN, word_count: 4, supplemental: false, random_words_to_add: 0) The similar issue will probably exist when using FixIt can be fixed easily as it would require changing that default values only. On the other hand, I'm not sure if it is a really unwanted behaviour, as otherwise all sentences generated using e.g. |
As @tjozwik mentioned, passing |
@Maxeeezy if the issue is resolved can we close this? |
Thank you, @sudeeptarlekar, the issue can be closed! |
The word_count oprtion for the Faker::Hipster.sentence is not working. It keeps choosing a random length of the sentence.
The text was updated successfully, but these errors were encountered: