-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example of creating a stereo agent #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome -- thanks @erikwijmans . Left a few comments on typos. Also, color frames look like they have BGR vs RGB color channel flip (likely cv2 expects the former channel order by default). Other than these small fixes, LGTM! 👍
I am so bad at remembering to do that..... |
… stereo-agent-example
… stereo-agent-example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome to see stereo pair in HSIM, some minor comments.
@erikwijmans since this PR has now been reviewed, shall we land it for release? |
* Stereo agent example * Add test * Add some comments * Render at 256 * Smoke test more * Mark as gfx * Typos, BGR vs RGB, and get ready for multiple examples to test! * Little change * Rename * Nits
Motivation and Context
See #56 for context!
This one adds an example of creating an agent that uses a stereo RGB pair or a stereo depth pair. The displaying to the user is done via cv2
How Has This Been Tested
Also via the new smoke test in pytest.
Types of changes