-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable phong shading and lighting configurations #489
Conversation
update resource manager to use new ShaderManager flat shading override for scenes
Great job on the benchmarks. |
Codecov Report
@@ Coverage Diff @@
## master #489 +/- ##
==========================================
+ Coverage 59.77% 59.83% +0.05%
==========================================
Files 158 158
Lines 7076 7096 +20
Branches 84 84
==========================================
+ Hits 4230 4246 +16
- Misses 2846 2850 +4
Continue to review full report at Codecov.
|
@matthewjmay Looks like we have functionality in habitat-api that gets broken by a singleton also. We have a threaded vector env (instead of the normal subprocess vector env) that is nice for debugging. This is fine with OpenGL contexts as those are local to a thread, but a singleton will get shared across threads. @mathfac do you know if its fine to limit the threaded vector env to just 1 sub-thread for a little bit? AFAIK, that functionality is only really useful for debugging where 1 process would likely be sufficient? |
@erikwijmans, great suggestion about making |
ETA is now -- see #496 :) I came to a conclusion that removing the deprecated functionality is the lesser evil, even though it would break things for existing users who didn't have a chance to upgrade yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's land this. 👍
* Phong shading and lighting configurations
Motivation and Context
This PR enables phong shading by default for added objects (scene remains flat shaded), and sets up the framework for multiple light configurations to be used, another step toward #319.
Without Phong (before)
With Phong
The default light configuration for dynamically added objects consists of lights at the corners of the scene bounding box.
In later PRs, the following functionality will be exposed through the simulator
How Has This Been Tested
SimTest.GetPinholeCameraRGBAObservation
shows no changes to images rendered with no lighting. Once lighting selection is exposed through simulator, I will add tests for different phong lighting configurationsBenchmarks
Scene Only
Tested locally with:
python examples/benchmark.py --scene ~/habitat-sim/data/scene_datasets/habitat-test-scenes/skokloster-castle.glb --max_frames 4000 --resolution=256 --num_procs=1
On branch master:
On this branch:
Should have no impact since scene is rendered with no lights
With Phong Shaded Physics objects
Tested locally with:
python examples/benchmark.py --enable_physics --scene ~/habitat-sim/data/scene_datasets/habitat-test-scenes/skokloster-castle.glb --max_frames 4000 --resolution=256 --num_procs=1
On branch master:
On this branch:
Negligible impact.
Types of changes
Checklist