-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rigidbody velocity get set #464
Conversation
…implemented through BulletRigidBody. Added test skeleton and viewer demo.
Codecov Report
@@ Coverage Diff @@
## master #464 +/- ##
==========================================
+ Coverage 57.81% 57.96% +0.14%
==========================================
Files 161 161
Lines 7067 7123 +56
Branches 84 84
==========================================
+ Hits 4086 4129 +43
- Misses 2981 2994 +13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my inline comments. Thanks!
Codecov Report
@@ Coverage Diff @@
## master #464 +/- ##
==========================================
+ Coverage 57.96% 59.19% +1.22%
==========================================
Files 161 165 +4
Lines 7123 7347 +224
Branches 84 84
==========================================
+ Hits 4129 4349 +220
- Misses 2994 2998 +4
Continue to review full report at Codecov.
|
Thanks for the comments. The viewer changes were really just to demonstrate the functionality in the videos and I've removed them until the full velocity control feature set is ready. |
* Add get/set instantaneous linear/angular velocity for RigidBody and PhysicsManager implemented through BulletRigidBody. Added C++ test.
Motivation and Context
We can currently manipulate objects kinematically via position|orientation and dynamically via force|torque. This change sets the stage for velocity control by adding support for getting|setting rigid body linear|angular velocity via Bullet physics.
Viewer demo updates: (for demo purposes: happy to modify/remove for final merge)
'E'
and anti-gravity mode'G'
for most recently added object with on-screen text to display current setting.commandVelocity
variable to store and apply a velocity control setting.Notes:
MotionType::KINEMATIC
orMotionType::STATIC
. In other words, it only currently enables velocity manipulation forMotionType::DYNAMIC BulletRigidObject
s.How Has This Been Tested
New C++ test and viewer demo:
Example 1: anti-grav velocity control of cheezit box
Example 2: velocity control with gravity of chef_can
Types of changes
Checklist