[sensor] extract out visual parts of Sensor into VisualSensor #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This is part of the Sensor refactor. Also removed a few APIs we were exporting to python that didn't really need to be exported.
msavva
approved these changes
Jan 20, 2020
src/esp/sensor/VisualSensor.h
Outdated
| namespace esp { | ||
| namespace sensor { | ||
|
|
||
| // Represents a sensor that provides data from the environment to an agent |
There was a problem hiding this comment.
May be good to make this a bit more constrained to provides visual data since this is a VisualSensor
* Make displayObservation pure virtual in Sensor class.
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
==========================================
- Coverage 64.49% 57.43% -7.06%
==========================================
Files 64 176 +112
Lines 2929 8134 +5205
Branches 84 84
==========================================
+ Hits 1889 4672 +2783
- Misses 1040 3462 +2422
Continue to review full report at Codecov.
|
Ram81
pushed a commit
to Ram81/habitat-web-sim
that referenced
this pull request
Dec 10, 2020
…cebookresearch#432) This is part of the Sensor refactor. Also removed a few APIs we were exporting to python that didn't really need to be exported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the Sensor refactor. The goal of this change is to bring the Sensor class into closer alignment with the new Sensor API design.
Also removed a few APIs we were exporting to python that didn't
really need to be exported.
Motivation and Context
Sensor refactor
How Has This Been Tested
SimTest
Types of changes
Checklist