-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imported objects configurable scaling #428
Conversation
…l tests to avoid code duplication.
… test confirming bug in margin setting between joined and unjoined objects.
…e to margin test. Fixed margin setting bugs.
Will be useful for domain randomization. Also, it's raining cheeseboxes :-). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The physics config parsing code is getting large enough that it may be time to pull it out of ResourceManager.cpp. We may also want to consider writing a code generator since the code is all following the same template.
Great point, I was thinking the same thing while writing this code. 😄 |
* Add configurable physics object scaling * Added test for visual and collision scaling
Motivation and Context
This change allows non-uniform scaling of objects via configuration of an object's template in
ResourceManager::physicsObjectLibrary_
.This will allow users to load a single object template and spawn multiple instances with varying scales into the scene.
Note: negative scales are allowed, tested, and stable. Visually, this can invert the mesh normals, allowing the camera to see through the surface of the object due to back-face culling. I didn't restrict this since it could be considered a feature (e.g. invert the scale to see inside a shape from the outside).
How Has This Been Tested
New C++ CI test.
Local testing in viewer:
Types of changes
Checklist