Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] TypeScript support #411

Merged
merged 2 commits into from
Jan 7, 2020

Conversation

apsdehal
Copy link
Contributor

@apsdehal apsdehal commented Jan 2, 2020

Motivation and Context

TypeScript enables type checking for JavaScript and will help improve quality of code on JS side.
This PR enables typescript compilation support and makes it work alongside ES6.

How Has This Been Tested

Same commands nothing has changed. A separate PR will be opened for moving files to .ts.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@apsdehal apsdehal requested a review from msbaines January 2, 2020 23:42
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 2, 2020
@codecov-io
Copy link

codecov-io commented Jan 3, 2020

Codecov Report

Merging #411 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #411   +/-   ##
=======================================
  Coverage   56.74%   56.74%           
=======================================
  Files         175      175           
  Lines        8094     8094           
  Branches       84       84           
=======================================
  Hits         4593     4593           
  Misses       3501     3501
Flag Coverage Δ
#CPP 52.35% <ø> (ø) ⬆️
#JavaScript 10% <ø> (ø) ⬆️
#Python 78.82% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af84038...05ee361. Read the comment docs.

@apsdehal apsdehal added this to the Better eng milestone Jan 3, 2020
@apsdehal apsdehal merged commit 4f2e020 into facebookresearch:master Jan 7, 2020
@apsdehal apsdehal deleted the typescript branch January 7, 2020 16:47
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
* [feature] TypeScript support

* Change back to index.js for webpack.config.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants