Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specified clang-tidy version 8 for contributing guidelines #408

Merged
merged 1 commit into from
Dec 29, 2019

Conversation

mathfac
Copy link
Contributor

@mathfac mathfac commented Dec 28, 2019

Motivation and Context

Specified clang-tidy version 8 for contributing guidelines, as our clang config isn't backward compatible.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 28, 2019
@mathfac mathfac self-assigned this Dec 28, 2019
@codecov-io
Copy link

codecov-io commented Dec 29, 2019

Codecov Report

Merging #408 into master will decrease coverage by 0.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
- Coverage   56.74%   55.96%   -0.79%     
==========================================
  Files         175      171       -4     
  Lines        8094     7950     -144     
  Branches       84       84              
==========================================
- Hits         4593     4449     -144     
  Misses       3501     3501
Flag Coverage Δ
#CPP 52.35% <ø> (ø) ⬆️
#JavaScript 10% <ø> (ø) ⬆️
#Python 77.42% <ø> (-1.41%) ⬇️
Impacted Files Coverage Δ
tests/test_sensors.py 100% <0%> (ø) ⬆️
habitat_sim/sensors/noise_models/__init__.py 100% <0%> (ø) ⬆️
...t_sim/sensors/noise_models/gaussian_noise_model.py
...ensors/noise_models/salt_and_pepper_noise_model.py
...at_sim/sensors/noise_models/speckle_noise_model.py
...at_sim/sensors/noise_models/poisson_noise_model.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f9755...c18822b. Read the comment docs.

@mathfac mathfac merged commit af84038 into master Dec 29, 2019
@mathfac mathfac deleted the mathfac-cont-clang branch December 29, 2019 23:12
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
…esearch#408)

Specified clang-tidy version 8 for contributing guidelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants