-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor PhysicsTest.cpp: add PhysicsManagerTest feature #397
Conversation
…l tests to avoid code duplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use a test fixture: https://github.com/google/googletest/blob/master/googletest/docs/primer.md
Thanks, this is nicer. 😄 |
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
==========================================
+ Coverage 55.57% 55.58% +0.01%
==========================================
Files 167 167
Lines 7862 7865 +3
Branches 82 82
==========================================
+ Hits 4369 4372 +3
Misses 3493 3493
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit.
…earch#397) * Refactor PhysicsTest.cpp to extract world/scene setup from individual tests to avoid code duplication.
Motivation and Context
In order to test physics functionality, the scene must first be loaded and initialized. This process would be duplicated for each test. This setup is now abstracted into PhysicsManagerTest feature which can be re-used by each physics test to avoid code duplication.
How Has This Been Tested
C++ tests still run and pass.
Types of changes
Checklist