-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[viewer] add FPS counter using imgui #355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plain and simple. Thank you! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking "iamgui" might be heavy in terms of development but clearly I am wrong! I sincerely appreciate your effort to bring it to us during the weekend.
I remember when I initialized #343, I directly applied a couple of Magnum libraries (fontManager, fonts, Renderer2D) to the "viewer", the reviewers required me to extract the "text drawing" in a separate class to keep the viewer clean and code re-usable. I hope "iamgui" would serve this purpose and address their concerns even though there is certain "iamgui" related logic exposed in the code (e.g., setBlendFunction, ImGui::Begin, SetWindowFontScale(...)). Hope they can tolerate it.
Thank you very much, @msbaines!
About implementation details:
I am not sure if it is possible to move the "text display" to the TOP-LEFT or TOP-RIGHT? That would make it perfect.
Also please make sure it can be compiled in --headless mode as well.
Also, would you consider adding a boolean switch to turn on/off the info display? |
Updated ObjNav Dataset to V1
Motivation and Context
Would be cool to be able to use imgui for HeadsUpDisplay
How Has This Been Tested
Ran viewer and verified that FPS counter is displayed correctly.
Types of changes
Checklist