-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix action space path #346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, do we have any test for demo runner that can cover this use case?
Added a test |
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
==========================================
+ Coverage 56.72% 56.74% +0.02%
==========================================
Files 151 153 +2
Lines 6740 7038 +298
==========================================
+ Hits 3823 3994 +171
- Misses 2917 3044 +127
Continue to review full report at Codecov.
|
Surprised that PR decreases coverage, the follower looks pretty uncovered in master. |
Looks like it counts |
The follower should be really well covered in master: https://github.com/facebookresearch/habitat-sim/blob/master/tests/test_greedy_follower.py This PR is just hooking it up correctly in the example script |
* Fix action space path * Add test
Motivation and Context
Actually hook-up the greedy follower to the action space path part of the example (this never got done for some reason).
Fixes #111
How Has This Been Tested
Via
python examples/example.py --compute_action_shortest_path
Types of changes