Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix action space path #346

Merged
merged 4 commits into from
Dec 3, 2019
Merged

Fix action space path #346

merged 4 commits into from
Dec 3, 2019

Conversation

erikwijmans
Copy link
Contributor

Motivation and Context

Actually hook-up the greedy follower to the action space path part of the example (this never got done for some reason).

Fixes #111

How Has This Been Tested

Via python examples/example.py --compute_action_shortest_path

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 11, 2019
Copy link
Contributor

@mathfac mathfac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, do we have any test for demo runner that can cover this use case?

@erikwijmans
Copy link
Contributor Author

Added a test

@codecov-io
Copy link

codecov-io commented Nov 26, 2019

Codecov Report

Merging #346 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
+ Coverage   56.72%   56.74%   +0.02%     
==========================================
  Files         151      153       +2     
  Lines        6740     7038     +298     
==========================================
+ Hits         3823     3994     +171     
- Misses       2917     3044     +127
Impacted Files Coverage Δ
examples/settings.py 100% <ø> (ø) ⬆️
tests/test_examples.py 100% <100%> (ø) ⬆️
examples/demo_runner.py 49.32% <100%> (ø)
habitat_sim/nav/greedy_geodesic_follower.py 96.22% <100%> (-0.07%) ⬇️
examples/example.py 75.71% <0%> (ø)
habitat_sim/simulator.py 94.17% <0%> (+1.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 175ea23...3c123aa. Read the comment docs.

@mathfac
Copy link
Contributor

mathfac commented Nov 26, 2019

Surprised that PR decreases coverage, the follower looks pretty uncovered in master.

@mosra
Copy link
Collaborator

mosra commented Nov 26, 2019

Looks like it counts import lines into coverage, and one of these got removed, which makes it a net negative :)

@erikwijmans
Copy link
Contributor Author

The follower should be really well covered in master: https://github.com/facebookresearch/habitat-sim/blob/master/tests/test_greedy_follower.py

This PR is just hooking it up correctly in the example script

@erikwijmans erikwijmans merged commit dedd554 into master Dec 3, 2019
@erikwijmans erikwijmans deleted the fix-action-path branch December 3, 2019 19:57
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
* Fix action space path

* Add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--compute_action_shortest_path says method not found
5 participants