Allow agent reference to be kept #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
mathfac
reviewed
Oct 18, 2019
mathfac
approved these changes
Oct 18, 2019
There was a problem hiding this comment.
@erikwijmans thank you, I checked the PR fixes all issues related to agent reference. Let's merge it.
@piotr-bojanowski, you can rebase on up to date master.
Ram81
pushed a commit
to Ram81/habitat-web-sim
that referenced
this pull request
Dec 10, 2020
* Fix issue where habitat-sim doesn't let you keep a reference to an agent gracefully * More agent keeping * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Habitat-sim currently crashes if you do
as the sensors have OpenGL related things, but the simulator owns the OpenGL context.
Also makes
sensorson the agent private, so we don't have to go down this rabbit hole further.How Has This Been Tested
With the test!
Types of changes