Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[esp/bindings_js] get semantic render working again #299

Merged
merged 1 commit into from
Oct 15, 2019
Merged

[esp/bindings_js] get semantic render working again #299

merged 1 commit into from
Oct 15, 2019

Conversation

msbaines
Copy link
Contributor

Fixed a typo that was preventing semantic render from working.

Motivation and Context

Fixes bug.

How Has This Been Tested

Verified that semantic information is now being rendered.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

[esp/bindings_js] get semantic render working again
9aa8ad4 
Fixed a typo that was preventing semantic render from working.
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 15, 2019
apsdehal
apsdehal approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@apsdehal apsdehal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad! Apologies about this.

@msbaines msbaines merged commit 7e9ff64 into master Oct 15, 2019
@msbaines msbaines deleted the fix-typo branch October 15, 2019 20:09
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
@msbaines
[esp/bindings_js] get semantic render working again (facebookresearch…
e1d648e 
…#299)

Fixed a typo that was preventing semantic render from working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apsdehal apsdehal apsdehal approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msbaines @apsdehal @facebook-github-bot