Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Physics usability improvements #231

Merged
merged 9 commits into from
Sep 23, 2019
Merged

Physics usability improvements #231

merged 9 commits into from
Sep 23, 2019

Commits on Sep 20, 2019

  1. Name the Bullet-enabling var consistently, turn it into a CMake option.

    @mosra
    mosra committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    143dec1 View commit details
    Browse the repository at this point in the history

  2. assets: use proper directory joining for physics object filenames. 

    This allows absolute filenames to be used inside the JSON configs.
    @mosra
    mosra committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    f8f67f9 View commit details
    Browse the repository at this point in the history

  3. viewer: printing this every frame actually slows everything down quit… 

    …e a lot.

Now you can't *see* it runs 60 FPS but you can *feel* it.
    @mosra
    mosra committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    a43975f View commit details
    Browse the repository at this point in the history

  4. viewer: improve the physics config file passing. 

     * Use an absolute default path so it doesn't depend on current working
   directory.
 * Instead of dying on an assert inside rapidjson, check file existence
   and fail gracefully with a clear message.
 * Use consistent naming scheme for the options.
    @mosra
    mosra committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    156ec26 View commit details
    Browse the repository at this point in the history

  5. viewer: exiting after an error shouldn't use a success return code.

    @mosra
    mosra committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    6c3ab6c View commit details
    Browse the repository at this point in the history

  6. viewer: --enable-physics w/o Bullet enabled is most probably an error. 

    So warn on that. People *might* still want to do this, so not making
this a hard error.
    @mosra
    mosra committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    6a44871 View commit details
    Browse the repository at this point in the history

  7. viewer: improve usability of the banana throwing. 

    When all files fail to load, it would crash because of a modulo
with zero. When physics is not enabled, the O key would silently do
nothing.
    @mosra
    mosra committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    c10dd2d View commit details
    Browse the repository at this point in the history

  8. viewer: enable at least a bit of MSAA for prettier screenshots.

    @mosra
    mosra committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    2555a89 View commit details
    Browse the repository at this point in the history

  9. Changed no Bullet WARNING in ResourceManager to be more helpful.

    @aclegg3
    aclegg3 committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    6a60eca View commit details
    Browse the repository at this point in the history