Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ASSERT with CORRADE_ASSERT in PTexMeshData.cpp #225

Merged
merged 10 commits into from
Sep 24, 2019
Merged

Commits on Sep 18, 2019

  1. Replce ASSERT with CORRADE_ASSERT in PTexMeshData.cpp

    If you look into the implementation of ASSERT, you will find that it actually cannot output error message when the condition is failed.
    
    Apply the CORRADE_ASSERT shipped with Corrade library instead.
    
    In this PR:
    -) replaced all the ASSERT with CORRADE_ASSERT;
    -) added "Error: " to some of the error messages;
    bigbike committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    2b36b09 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2019

  1. minor

    bigbike committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    eef7bcc View commit details
    Browse the repository at this point in the history
  2. address reviewer's concerns.

    -) replaced "Error" with class::functionName at the beginning of every error message;
    -) used CORRADE_ASSERT_UNREACHABLE;
    bigbike committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    18abdf4 View commit details
    Browse the repository at this point in the history
  3. minor

    bigbike committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    e9a3c17 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2019

  1. Configuration menu
    Copy the full SHA
    27e16f0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7716200 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2019

  1. remove space

    bigbike committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    b6324e1 View commit details
    Browse the repository at this point in the history
  2. minor

    bigbike committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    f6a09e1 View commit details
    Browse the repository at this point in the history
  3. minor

    bigbike committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    c7d707d View commit details
    Browse the repository at this point in the history
  4. minor

    bigbike committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    d5cd589 View commit details
    Browse the repository at this point in the history