-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ASSERT with CORRADE_ASSERT in PTexMeshData.cpp #225
Merged
Commits on Sep 18, 2019
-
Replce ASSERT with CORRADE_ASSERT in PTexMeshData.cpp
If you look into the implementation of ASSERT, you will find that it actually cannot output error message when the condition is failed. Apply the CORRADE_ASSERT shipped with Corrade library instead. In this PR: -) replaced all the ASSERT with CORRADE_ASSERT; -) added "Error: " to some of the error messages;
Configuration menu - View commit details
-
Copy full SHA for 2b36b09 - Browse repository at this point
Copy the full SHA 2b36b09View commit details
Commits on Sep 19, 2019
-
Configuration menu - View commit details
-
Copy full SHA for eef7bcc - Browse repository at this point
Copy the full SHA eef7bccView commit details -
-) replaced "Error" with class::functionName at the beginning of every error message; -) used CORRADE_ASSERT_UNREACHABLE;
Configuration menu - View commit details
-
Copy full SHA for 18abdf4 - Browse repository at this point
Copy the full SHA 18abdf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9a3c17 - Browse repository at this point
Copy the full SHA e9a3c17View commit details
Commits on Sep 23, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 27e16f0 - Browse repository at this point
Copy the full SHA 27e16f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7716200 - Browse repository at this point
Copy the full SHA 7716200View commit details
Commits on Sep 24, 2019
-
Configuration menu - View commit details
-
Copy full SHA for b6324e1 - Browse repository at this point
Copy the full SHA b6324e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6a09e1 - Browse repository at this point
Copy the full SHA f6a09e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7d707d - Browse repository at this point
Copy the full SHA c7d707dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5cd589 - Browse repository at this point
Copy the full SHA d5cd589View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.