Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay renderer partial deletion #2136

Merged
merged 9 commits into from
Jun 27, 2023
Merged

Replay renderer partial deletion #2136

merged 9 commits into from
Jun 27, 2023

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Jun 25, 2023

Motivation and Context

The batch renderer can only delete full scenes - it cannot delete single objects.

To circumvent this, deletions are processed as such:

  1. Latest transforms are cached.
  2. All instances are deleted.
  3. Remaining instances are re-created.
  4. Latest transforms are re-applied.

How Has This Been Tested

Tested locally on PPO training and added a unit test.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@0mdc 0mdc requested a review from eundersander June 25, 2023 21:54
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 25, 2023
src/esp/gfx/replay/Player.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. Let me know when I should take another look!

src/esp/gfx/replay/Player.cpp Outdated Show resolved Hide resolved
src/esp/gfx/replay/Player.cpp Outdated Show resolved Hide resolved
src/esp/gfx/replay/Player.cpp Outdated Show resolved Hide resolved
src/esp/gfx/replay/Player.cpp Outdated Show resolved Hide resolved
src/esp/gfx/replay/Player.h Outdated Show resolved Hide resolved
@0mdc 0mdc marked this pull request as ready for review June 26, 2023 19:35
Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test that will trigger this code? BatchReplayRendererTest::testIntegration is close but it doesn't do any deletions.

src/esp/gfx/replay/Player.cpp Show resolved Hide resolved
@0mdc 0mdc changed the title [Draft] Replay renderer partial deletion Replay renderer partial deletion Jun 27, 2023
Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -0,0 +1,169 @@
// Copyright (c) Meta Platforms, Inc. and its affiliates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this code was moved from BatchReplayRenderer.cpp without changes so I'm not looking closely at this file.

@0mdc 0mdc merged commit aa731e7 into main Jun 27, 2023
@0mdc 0mdc deleted the replay-partial-deletion branch June 27, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants