Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rearrange_pick_dataset_v1 #1664

Merged
merged 5 commits into from
Feb 17, 2022
Merged

Conversation

vincentpierre
Copy link
Contributor

Motivation and Context

Adding a v1 of the data set for the pick task using the new data generator schema.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vincentpierre vincentpierre added the do not merge Not ready to merge. This label should block merging. label Feb 14, 2022
@vincentpierre vincentpierre self-assigned this Feb 14, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 14, 2022
@aclegg3
Copy link
Contributor

aclegg3 commented Feb 14, 2022

Instead of adding a new entry, you should just replace the links and bump the version on the existing entry. The downloader will handle the versioning for users.

@ASzot
Copy link
Contributor

ASzot commented Feb 15, 2022

After we bump the version then the tests on Habitat Lab will fail though @aclegg3. How do we resolve this dependency? We need the new dataset for the tests here to pass: facebookresearch/habitat-lab#774.

@aclegg3
Copy link
Contributor

aclegg3 commented Feb 15, 2022

After we bump the version then the tests on Habitat Lab will fail though @aclegg3. How do we resolve this dependency? We need the new dataset for the tests here to pass: facebookresearch/habitat-lab#774.

I see, this new version doesn't support the current testing scenario in main.

One option would be to leave this PR un-merged and edit the CI config in that Habitat-lab branch to grab this PR for the data download step before pulling and installing main. When we are ready to merge that PR, we'll also merge this and remove that extra step.

@vincentpierre
Copy link
Contributor Author

I think we want the data to be on a different path than the previous version. I start to think it would be better to have 2 different entries for these 2 datasets (like in the last commit)

@vincentpierre vincentpierre marked this pull request as ready for review February 16, 2022 22:25
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the reasoning here. We'll add a new entry now to support testing on existing main and the dev branch. Once everything is merged and it becomes irrelevant, we can remove the old entry.

src_python/habitat_sim/utils/datasets_download.py Outdated Show resolved Hide resolved
src_python/habitat_sim/utils/datasets_download.py Outdated Show resolved Hide resolved
vincentpierre and others added 2 commits February 16, 2022 14:38
Co-authored-by: Alexander Clegg <alexclegg@fb.com>
Co-authored-by: Alexander Clegg <alexclegg@fb.com>
@vincentpierre vincentpierre merged commit 61ad28d into main Feb 17, 2022
@jturner65 jturner65 deleted the dowloader_replica_cad_v1 branch November 29, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. do not merge Not ready to merge. This label should block merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants