Skip to content

Commit

Permalink
Temporarily work around lost code coverage reports. (#1892)
Browse files Browse the repository at this point in the history
Getting a lot of these due to the coverage being collected after the
Audio build, losing the coverage collected earlier:

libgcov profiling error:/home/circleci/project/habitat-sim/build/esp/bindings/CMakeFiles/habitat_sim_bindings.dir/Bindings.cpp.gcda:overwriting an existing profile data with a different timestamp

With this change the coverage is back at 60% (from 40%), and
still includes also everything from the Audio build. The better
long-term solution, however, would be like something in
#1860.
  • Loading branch information
mosra authored Oct 7, 2022
1 parent 6ad4020 commit befd171
Showing 1 changed file with 22 additions and 18 deletions.
40 changes: 22 additions & 18 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -583,24 +583,7 @@ jobs:
. ~/emsdk/emsdk_env.sh
# Generate JS CodeConv
npm run test_with_coverage
- run:
name: Build, install habitat-sim with audio and run audio_agent script
no_output_timeout: 10m
command: |
export PATH=$HOME/miniconda/bin:$PATH
. activate habitat;
cd habitat-sim
pip install -r requirements.txt --progress-bar off
pip install imageio imageio-ffmpeg
git submodule update --init --recursive --jobs 8
python -u setup.py install --build-type "Release" --lto --headless --audio
python examples/tutorials/audio_agent.py
- save_cache:
key: ccache-{{ arch }}-{{ .Branch }}-{{ .BuildNum }}
background: true
paths:
- /home/circleci/.ccache
- run:
- run: &upload_coverage
name: Upload test coverage
command: |
export PATH=$HOME/miniconda/bin:/usr/local/cuda/bin:$PATH
Expand All @@ -623,6 +606,27 @@ jobs:
#lcov --remove coverage.info "*/test/*" --output-file coverage.info > /dev/null
#lcov --remove coverage.info "*/tests/*" --output-file coverage.info > /dev/null
./codecov -f coverage.info -cF CPP
- run:
name: Build, install habitat-sim with audio and run audio_agent script
no_output_timeout: 10m
command: |
export PATH=$HOME/miniconda/bin:$PATH
. activate habitat;
cd habitat-sim
pip install -r requirements.txt --progress-bar off
pip install imageio imageio-ffmpeg
git submodule update --init --recursive --jobs 8
python -u setup.py install --build-type "Release" --lto --headless --audio
python examples/tutorials/audio_agent.py
- save_cache:
key: ccache-{{ arch }}-{{ .Branch }}-{{ .BuildNum }}
background: true
paths:
- /home/circleci/.ccache
# Uploading test coverage again for code changed by the above rebuild.
# TODO: https://github.com/facebookresearch/habitat-sim/pull/1860 fixes
# this better, remove once it's merged
- run: *upload_coverage



Expand Down

0 comments on commit befd171

Please sign in to comment.