Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fiber] Log Component Renders to Custom Performance Track #30967

Merged
merged 8 commits into from
Sep 16, 2024
+285 −49
Merged

[Fiber] Log Component Renders to Custom Performance Track #30967

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3b80acf
Missing comment
sebmarkbage Sep 15, 2024
632cea8
Always visit nodes that had any actual duration this commit in the pa…
sebmarkbage Sep 15, 2024
598775b
Track complete time
sebmarkbage Sep 13, 2024
1e67729
Pass the endTime recursively through the passive commit phase
sebmarkbage Sep 15, 2024
5545a58
Track startTime of siblings outside of the Profiler mode tree
sebmarkbage Sep 15, 2024
c574330
Log start/end time of a Component's render track after it commits
sebmarkbage Sep 15, 2024
b03e3ee
Name the track by the committed lanes
sebmarkbage Sep 16, 2024
2a1903d
Feature test
sebmarkbage Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/react-reconciler/src/__tests__/ReactSuspenseList-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @emails react-core
* @jest-environment node
*/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mattered because without the node environment it didn't have performance.measure. However, I now feature test it too.

let React;
let ReactNoop;
let Scheduler;
Expand Down