Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fiber] Log Component Renders to Custom Performance Track #30967

Merged
merged 8 commits into from
Sep 16, 2024
Merged

[Fiber] Log Component Renders to Custom Performance Track #30967

merged 8 commits into from
Sep 16, 2024
+285 −49

Commits on Sep 16, 2024

  1. Missing comment

    @sebmarkbage
    sebmarkbage committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3b80acf View commit details
    Browse the repository at this point in the history

  2. Always visit nodes that had any actual duration this commit in the pa… 

    …ssive phase

This lets us log all those nodes.

actualDuration includes anything in the subtree as well.

The parent path to a Profiler component won't have actualDuration set but
it'll instead have the Passive flag set which is used for onPostCommit.
    @sebmarkbage
    sebmarkbage committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    632cea8 View commit details
    Browse the repository at this point in the history

  3. Track complete time 

    We'll need this to know when the last component's end time is.
    @sebmarkbage
    sebmarkbage committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    598775b View commit details
    Browse the repository at this point in the history

  4. Pass the endTime recursively through the passive commit phase 

    The endTime is defined as just the next sibling's start time or if this is
the terminal leaf then it is the complete time of the whole render.

It is not enough to use actualStartTime + actualDuration because that number
doesn't include yields. So this time is the time including any yields.
    @sebmarkbage
    sebmarkbage committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1e67729 View commit details
    Browse the repository at this point in the history

  5. Track startTime of siblings outside of the Profiler mode tree 

    This way we can compute the end time of the next sibling.

In the case where DEV or DevTools is installed this is on everywhere anyway
but it is unfortunate that if you run Profiling build without a Profiler
this would track every component anyway.
    @sebmarkbage
    sebmarkbage committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    5545a58 View commit details
    Browse the repository at this point in the history

  6. Log start/end time of a Component's render track after it commits

    @sebmarkbage
    sebmarkbage committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c574330 View commit details
    Browse the repository at this point in the history

  7. Name the track by the committed lanes

    @sebmarkbage
    sebmarkbage committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    b03e3ee View commit details
    Browse the repository at this point in the history

  8. Feature test

    @sebmarkbage
    sebmarkbage committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2a1903d View commit details
    Browse the repository at this point in the history