Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler] Flatten scopes based on fallthrough, not scope range #30398

Merged
merged 3 commits into from
Jul 24, 2024
Merged

[compiler] Flatten scopes based on fallthrough, not scope range #30398

merged 3 commits into from
Jul 24, 2024

Commits on Jul 19, 2024

  1. [compiler] Flatten scopes based on fallthrough, not scope range 

    Once we create scopes, we should prefer to use the block structure to identify active scope ranges rather than the scope range. They _should_ always be in sync, but ultimately the block structure determine the active range (ie the id of the 'scope' terminal and the terminal's fallthrough block).

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    421b3e7 View commit details
    Browse the repository at this point in the history

  2. Update on "[compiler] Flatten scopes based on fallthrough, not scope … 

    …range"

Once we create scopes, we should prefer to use the block structure to identify active scope ranges rather than the scope range. They _should_ always be in sync, but ultimately the block structure determine the active range (ie the id of the 'scope' terminal and the terminal's fallthrough block).

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    6a357e7 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. rebase on "[compiler] Flatten scopes based on fallthrough, not scope … 

    …range"

Once we create scopes, we should prefer to use the block structure to identify active scope ranges rather than the scope range. They _should_ always be in sync, but ultimately the block structure determine the active range (ie the id of the 'scope' terminal and the terminal's fallthrough block).

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d45ce65 View commit details
    Browse the repository at this point in the history