-
Notifications
You must be signed in to change notification settings - Fork 46.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compiler] Flatten scopes based on fallthrough, not scope range #30398
[compiler] Flatten scopes based on fallthrough, not scope range #30398
Conversation
Once we create scopes, we should prefer to use the block structure to identify active scope ranges rather than the scope range. They _should_ always be in sync, but ultimately the block structure determine the active range (ie the id of the 'scope' terminal and the terminal's fallthrough block). [ghstack-poisoned]
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…range" Once we create scopes, we should prefer to use the block structure to identify active scope ranges rather than the scope range. They _should_ always be in sync, but ultimately the block structure determine the active range (ie the id of the 'scope' terminal and the terminal's fallthrough block). [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! Our instruction ids are not guaranteed to be always increasing (e.g. BuildReactiveScopeTerminalsHIR
for example inserts scope terminals, re-using existing instruction ids)
EDIT: ohhh nvm, thanks for fixing in #30399
…range" Once we create scopes, we should prefer to use the block structure to identify active scope ranges rather than the scope range. They _should_ always be in sync, but ultimately the block structure determine the active range (ie the id of the 'scope' terminal and the terminal's fallthrough block). [ghstack-poisoned]
Once we create scopes, we should prefer to use the block structure to identify active scope ranges rather than the scope range. They _should_ always be in sync, but ultimately the block structure determine the active range (ie the id of the 'scope' terminal and the terminal's fallthrough block). ghstack-source-id: 730b6d1cfaf0eb689d71057c78a48045ac4fb11c Pull Request resolved: #30398
Once we create scopes, we should prefer to use the block structure to identify active scope ranges rather than the scope range. They _should_ always be in sync, but ultimately the block structure determine the active range (ie the id of the 'scope' terminal and the terminal's fallthrough block). ghstack-source-id: 730b6d1cfaf0eb689d71057c78a48045ac4fb11c Pull Request resolved: facebook#30398
Once we create scopes, we should prefer to use the block structure to identify active scope ranges rather than the scope range. They _should_ always be in sync, but ultimately the block structure determine the active range (ie the id of the 'scope' terminal and the terminal's fallthrough block). ghstack-source-id: 730b6d1cfaf0eb689d71057c78a48045ac4fb11c Pull Request resolved: facebook#30398
Once we create scopes, we should prefer to use the block structure to identify active scope ranges rather than the scope range. They _should_ always be in sync, but ultimately the block structure determine the active range (ie the id of the 'scope' terminal and the terminal's fallthrough block). ghstack-source-id: 730b6d1cfaf0eb689d71057c78a48045ac4fb11c Pull Request resolved: facebook#30398
Once we create scopes, we should prefer to use the block structure to identify active scope ranges rather than the scope range. They _should_ always be in sync, but ultimately the block structure determine the active range (ie the id of the 'scope' terminal and the terminal's fallthrough block). ghstack-source-id: 730b6d1cfaf0eb689d71057c78a48045ac4fb11c Pull Request resolved: facebook#30398
Once we create scopes, we should prefer to use the block structure to identify active scope ranges rather than the scope range. They _should_ always be in sync, but ultimately the block structure determine the active range (ie the id of the 'scope' terminal and the terminal's fallthrough block). ghstack-source-id: 730b6d1cfaf0eb689d71057c78a48045ac4fb11c Pull Request resolved: facebook#30398
Once we create scopes, we should prefer to use the block structure to identify active scope ranges rather than the scope range. They _should_ always be in sync, but ultimately the block structure determine the active range (ie the id of the 'scope' terminal and the terminal's fallthrough block). ghstack-source-id: 730b6d1cfaf0eb689d71057c78a48045ac4fb11c Pull Request resolved: facebook#30398
Stack from ghstack (oldest at bottom):
Once we create scopes, we should prefer to use the block structure to identify active scope ranges rather than the scope range. They should always be in sync, but ultimately the block structure determine the active range (ie the id of the 'scope' terminal and the terminal's fallthrough block).