Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FB build for ReactReconcilerConstants #29003

Merged
merged 2 commits into from
May 6, 2024

Conversation

jackpope
Copy link
Contributor

@jackpope jackpope commented May 6, 2024

In order to integrate the react-reconciler build created in #28880 with third party libraries, we need to have matching react-reconciler/constants to go with it.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 6, 2024
Copy link
Member

@kassens kassens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might have to update some sync config. Let's see

@react-sizebot
Copy link

react-sizebot commented May 6, 2024

Comparing: 46abd7b...947111a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 492.61 kB 492.61 kB = 87.88 kB 87.88 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 498.86 kB 498.86 kB = 88.93 kB 88.93 kB
facebook-www/ReactDOM-prod.classic.js = 591.22 kB 591.22 kB = 103.96 kB 103.96 kB
facebook-www/ReactDOM-prod.modern.js = 567.44 kB 567.44 kB = 100.36 kB 100.36 kB
facebook-www/ReactReconcilerConstants-dev.classic.js +∞% 0.00 kB 1.29 kB +∞% 0.00 kB 0.51 kB
facebook-www/ReactReconcilerConstants-dev.modern.js +∞% 0.00 kB 1.29 kB +∞% 0.00 kB 0.51 kB
facebook-www/ReactReconcilerConstants-prod.classic.js +∞% 0.00 kB 0.54 kB +∞% 0.00 kB 0.32 kB
facebook-www/ReactReconcilerConstants-prod.modern.js +∞% 0.00 kB 0.54 kB +∞% 0.00 kB 0.32 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactReconcilerConstants-dev.classic.js +∞% 0.00 kB 1.29 kB +∞% 0.00 kB 0.51 kB
facebook-www/ReactReconcilerConstants-dev.modern.js +∞% 0.00 kB 1.29 kB +∞% 0.00 kB 0.51 kB
facebook-www/ReactReconcilerConstants-prod.classic.js +∞% 0.00 kB 0.54 kB +∞% 0.00 kB 0.32 kB
facebook-www/ReactReconcilerConstants-prod.modern.js +∞% 0.00 kB 0.54 kB +∞% 0.00 kB 0.32 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 947111a

@jackpope jackpope merged commit 5d29478 into facebook:main May 6, 2024
38 checks passed
@jackpope jackpope deleted the fb-react-reconciler-constants branch May 6, 2024 15:32
github-actions bot pushed a commit that referenced this pull request May 6, 2024
In order to integrate the `react-reconciler` build created in #28880
with third party libraries, we need to have matching
`react-reconciler/constants` to go with it.

DiffTrain build for [5d29478](5d29478)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants