Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devtools: Streamline getting extension from branch #28975

Merged
merged 1 commit into from
May 2, 2024

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented May 2, 2024

Stack:

  1. Devtools: Streamline getting extension from branch #28975 <--- You're here
  2. Devtools: Fix build-for-devtools #28976
  3. DevTools: Fix inspecting components with multiple reads of the same Context in React 17 #28974

Summary

For manual e2e testing, I oftentimes just need the extension for the browser I'm using. So I'm adding separate artifacts just for Chrome and Firefox extension instead of a single tarball with both. Avoids one unpack step and is also easier for external people to grab a nightly build of the extension.

How did you test this change?

@react-sizebot
Copy link

react-sizebot commented May 2, 2024

Comparing: 4508873...ba75d2d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
facebook-www/ReactDOM-prod.classic.js = 591.11 kB 591.11 kB = 103.94 kB 103.94 kB
facebook-www/ReactDOM-prod.modern.js = 567.33 kB 567.33 kB = 100.34 kB 100.34 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against ba75d2d

@eps1lon eps1lon marked this pull request as ready for review May 2, 2024 14:32
@eps1lon eps1lon requested a review from hoxyq May 2, 2024 14:35
@eps1lon eps1lon merged commit c44e9d1 into facebook:main May 2, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants