Fix escaping in action error URL #27273

sebmarkbage · 2023-08-22T22:26:16Z

This URL is generated on the client (there's an equivalent but shorter SSR version too) when a function is used as an action. It should never happen but it'll be invoked if a form is manually submitted or event is stopped early.

The ' wasn't escaped so this yielded invalid syntax. Which is an error too but much less helpful. missing ) after argument list. Added a test that evals to make sure it's correct syntax.

react-sizebot · 2023-08-22T22:30:13Z

Comparing: 31034b6...fb437fd

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	165.59 kB	165.59 kB	=	51.88 kB	51.88 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	173.15 kB	173.15 kB	=	54.20 kB	54.20 kB
facebook-www/ReactDOM-prod.classic.js	=	569.82 kB	569.82 kB	=	100.37 kB	100.37 kB
facebook-www/ReactDOM-prod.modern.js	=	553.62 kB	553.62 kB	=	97.53 kB	97.53 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against fb437fd

gnoff

I would just make it “you are” but this works

This URL is generated on the client (there's an equivalent but shorter SSR version too) when a function is used as an action. It should never happen but it'll be invoked if a form is manually submitted or event is stopped early. The `'` wasn't escaped so this yielded invalid syntax. Which is an error too but much less helpful. `missing ) after argument list`. Added a test that evals to make sure it's correct syntax.

This URL is generated on the client (there's an equivalent but shorter SSR version too) when a function is used as an action. It should never happen but it'll be invoked if a form is manually submitted or event is stopped early. The `'` wasn't escaped so this yielded invalid syntax. Which is an error too but much less helpful. `missing ) after argument list`. Added a test that evals to make sure it's correct syntax. DiffTrain build for commit 856dc5e.

sebmarkbage requested review from gnoff and acdlite August 22, 2023 22:26

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 22, 2023

sebmarkbage force-pushed the fixactionerror branch from c5f1dfa to a3d31b1 Compare August 22, 2023 22:36

Fix escaping in action error URL

fb437fd

sebmarkbage force-pushed the fixactionerror branch from a3d31b1 to fb437fd Compare August 22, 2023 22:37

gnoff approved these changes Aug 22, 2023

View reviewed changes

sebmarkbage merged commit 856dc5e into facebook:main Aug 22, 2023
36 checks passed

acdlite mentioned this pull request Sep 14, 2023

Update React from dd480ef92 to d6dcad6a8. vercel/next.js#55399

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix escaping in action error URL #27273

Fix escaping in action error URL #27273

sebmarkbage commented Aug 22, 2023 •

edited

Loading

react-sizebot commented Aug 22, 2023 •

edited

Loading

gnoff left a comment

Fix escaping in action error URL #27273

Fix escaping in action error URL #27273

Conversation

sebmarkbage commented Aug 22, 2023 • edited Loading

react-sizebot commented Aug 22, 2023 • edited Loading

Critical size changes

Significant size changes

gnoff left a comment

Choose a reason for hiding this comment

sebmarkbage commented Aug 22, 2023 •

edited

Loading

react-sizebot commented Aug 22, 2023 •

edited

Loading