Selective Hydration: Don't suspend if showing fallback #27230

acdlite · 2023-08-14T17:20:29Z

A transition that flows into a dehydrated boundary should not suspend if the boundary is showing a fallback.

This is related to another issue where Fizz streams in the initial HTML after a client navigation has already happened. That issue is not fixed by this commit, but it does make it less likely. Need to think more about the larger issue.

react-sizebot · 2023-08-14T17:25:00Z

Comparing: b4cdd3e...22abdff

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	165.59 kB	165.61 kB	=	51.88 kB	51.87 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	173.43 kB	173.44 kB	=	54.24 kB	54.25 kB
facebook-www/ReactDOM-prod.classic.js	=	569.92 kB	569.80 kB	=	100.38 kB	100.39 kB
facebook-www/ReactDOM-prod.modern.js	=	553.72 kB	553.60 kB	=	97.54 kB	97.54 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 22abdff

A transition that flows into a dehydrated boundary should not suspend if the boundary is showing a fallback. This is related to another issue where Fizz streams in the initial HTML after a client navigation has already happened. That issue is not fixed by this commit, but it does make it less likely. Need to think more about the larger issue.

A transition that flows into a dehydrated boundary should not suspend if the boundary is showing a fallback. This is related to another issue where Fizz streams in the initial HTML after a client navigation has already happened. That issue is not fixed by this commit, but it does make it less likely. Need to think more about the larger issue. DiffTrain build for [ab31a9e](ab31a9e)

A transition that flows into a dehydrated boundary should not suspend if the boundary is showing a fallback. This is related to another issue where Fizz streams in the initial HTML after a client navigation has already happened. That issue is not fixed by this commit, but it does make it less likely. Need to think more about the larger issue.

A transition that flows into a dehydrated boundary should not suspend if the boundary is showing a fallback. This is related to another issue where Fizz streams in the initial HTML after a client navigation has already happened. That issue is not fixed by this commit, but it does make it less likely. Need to think more about the larger issue. DiffTrain build for commit ab31a9e.

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 14, 2023

acdlite requested a review from sebmarkbage August 14, 2023 17:26

sebmarkbage approved these changes Aug 15, 2023

View reviewed changes

acdlite force-pushed the dont-suspend-dehydrated-fallback branch from ee049cd to 22abdff Compare August 25, 2023 00:03

acdlite merged commit ab31a9e into facebook:main Aug 25, 2023
2 of 23 checks passed

acdlite mentioned this pull request Sep 14, 2023

Update React from dd480ef92 to d6dcad6a8. vercel/next.js#55399

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Selective Hydration: Don't suspend if showing fallback #27230

Selective Hydration: Don't suspend if showing fallback #27230

acdlite commented Aug 14, 2023

react-sizebot commented Aug 14, 2023 •

edited

Loading

Selective Hydration: Don't suspend if showing fallback #27230

Selective Hydration: Don't suspend if showing fallback #27230

Conversation

acdlite commented Aug 14, 2023

react-sizebot commented Aug 14, 2023 • edited Loading

Critical size changes

Significant size changes

react-sizebot commented Aug 14, 2023 •

edited

Loading