Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Move Everything to ES Modules in Builds #18094

Closed
wants to merge 9 commits into from
Closed

[WIP] Move Everything to ES Modules in Builds #18094

wants to merge 9 commits into from

Commits on Feb 21, 2020

  1. Remove commonjs plugin for rollup 

    We shouldn't need this and we accidentally rely on it just by it existing.
    @sebmarkbage
    sebmarkbage committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    2895ebf View commit details
    Browse the repository at this point in the history

  2. Change ReactVersion from CJS to ES module

    @sebmarkbage
    sebmarkbage committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    4a8e91e View commit details
    Browse the repository at this point in the history

  3. Change all the forwarding entry points to use ES modules

    @sebmarkbage
    sebmarkbage committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    ccb560e View commit details
    Browse the repository at this point in the history

  4. Export star from reconciler bundles and react-refresh 

    These were conditionally trying to export the default before but they
never actually exported a default. Same things with react-refresh.

For Debug Tools I stuck with exporting default for now.

This will now cause Rollup to mutate the exports object so I changed
the wrappers. I don't know why the wrappers can't just use shadowing but
I changed it to use shadowing so we don't have to use the mutation hack.
    @sebmarkbage
    sebmarkbage committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    7ff5ff0 View commit details
    Browse the repository at this point in the history

  5. Ensure eslint-plugin and react-art exports a default

    @sebmarkbage
    sebmarkbage committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    e75ed1f View commit details
    Browse the repository at this point in the history

  6. Switch interactions to star exports 

    This will have esModule compatibility flag on them. They should ideally
export default instead.
    @sebmarkbage
    sebmarkbage committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    3d7f1f1 View commit details
    Browse the repository at this point in the history

  7. Check in a forked version of object-assign 

    This one uses ES modules so that we can inline it into UMD builds.
    @sebmarkbage
    sebmarkbage committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    753014e View commit details
    Browse the repository at this point in the history

  8. Check in a forked version of prop-types/checkPropTypes that used ES m… 

    …odules

This shouldn't change and is really mostly barely supported.

It's better to control this if we're going to inline it anyway.
    @sebmarkbage
    sebmarkbage committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    fdc9d99 View commit details
    Browse the repository at this point in the history

  9. jest-react and react-debug-tools should have object-assign as a depen… 

    …dency not inlined

It uses spread or Object.assign in a single place which takes on this dep. :(
    @sebmarkbage
    sebmarkbage committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    07e86fb View commit details
    Browse the repository at this point in the history