[WIP] Move Everything to ES Modules in Builds #18094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't need this and we accidentally rely on it just by it existing.
These were conditionally trying to export the default before but they never actually exported a default. Same things with react-refresh. For Debug Tools I stuck with exporting default for now. This will now cause Rollup to mutate the exports object so I changed the wrappers. I don't know why the wrappers can't just use shadowing but I changed it to use shadowing so we don't have to use the mutation hack.
This will have esModule compatibility flag on them. They should ideally export default instead.
This one uses ES modules so that we can inline it into UMD builds.
…odules This shouldn't change and is really mostly barely supported. It's better to control this if we're going to inline it anyway.
…dency not inlined It uses spread or Object.assign in a single place which takes on this dep. :(
facebook-github-bot
added
CLA Signed
React Core Team
TrySound
reviewed
Feb 21, 2020
| @@ -0,0 +1,97 @@ | |||
| /* | |||
| object-assign | |||
| } | ||
| }; | ||
|
|
||
| export default checkPropTypes; |
| @@ -9,6 +9,28 @@ | |||
|
|
|||
| 'use strict'; | |||
There was a problem hiding this comment.
Maybe remove use strict everywhere?
|
Done in other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that our loose reliance on CommonJS isn't really letting Rollup do its best work. It's also covering up a bunch of quirks that cause other issues and this ends up leaking. We really only intended it to be used to suck in requires into UMD builds. Unfortunately it also means that we're actually inlining in a bunch of builds accidentally too.
The usage of CommonJS at the export level also covers up a bunch of issues by converting it first into an intermediate layer of CommonJS and then back again.
I want to get to a point where we can remove the CommonJS plugin from Rollup. I was hoping we could just fork the object-assign and prop-types ones because 1) both of these are kind of frozen and we should ideally get rid of the dep in the next version 2) umds are likely to get dropped soon too anyway. Unfortunately react-art also supports UMD, for some reason, and it's harder to fork all of art. I might end up keeping the CommonJS plugin but only for ART for this reason until we can kill those UMD bundles.
We should also start preparing for actually exporting ES modules. Right now we're not very rigid with how we export things. We should be always exporting a default for now since that gives us the best CommonJS output. We can't start exporting the esModule flag since that would start breaking things.
(Although I settled on just doing that for react-interactions because it was easier and it's FB only.)
However, this means that importing named imports etc. don't work. Including in our own code. Like DevTools. So we'll need to fix that up too.
There's a bunch to do here and I'm really just getting started.