Fix 9402 #12451
Fix 9402 #12451
Conversation
|
cc @nhunzaker |
|
I haven't evaluated the code yet, but I wanted to reach out to say that this is on my radar. I should be able to review this first thing tomorrow morning. Thanks for sending this out! |
| this.state = { | ||
| value: 0, | ||
| }; | ||
| } |
There was a problem hiding this comment.
Since you have a class field for inputRef, what do you think about assigning state this way too? Like:
state = {
value: 0,
}
| } | ||
| /> | ||
| </div> | ||
| ); |
There was a problem hiding this comment.
Could you remove the wrapping <div> and <h1> tags? That way it's clearer what this component is trying to test.
There was a problem hiding this comment.
Yup sure, make sense.
|
@nhunzaker Hey apart from the 2 comments, is everything else is fine? |
|
@antoaravinth I think this addresses the issue, however I'm concerned about edge cases with number inputs if we ship this feature. I've laid out my concerns in the issue (#9402 (comment)) |
|
Hey! I'm sorry we never got back to you about this but it seems this is now really outdated. If this is something that still makes sense to the latest master version of React, please send a new PR with this change :) |
Hello,
This fixes #9402.
I have tested in chrome, firefox and safari after the build. The issue is fixed. Also test, prod-test are running fine. Let me know if anything else is needed from my end. cc @nhunzaker