-
Notifications
You must be signed in to change notification settings - Fork 46.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A number input will always have left pad 0 though parseFloat value in onChange #9402
Comments
cc @aweary |
Thanks for the report @HaydnChen, I verified the bug issue with https://jsfiddle.net/84v837e9/ and have found the root cause. |
To give some insight, the issue is caused by ReactDOMInput.js#L192-L200 // Simulate `input.valueAsNumber`. IE9 does not support it
var valueAsNumber = parseFloat(node.value, 10) || 0;
// eslint-disable-next-line
if (value != valueAsNumber) {
// Cast `value` to a string to ensure the value is set correctly. While
// browsers typically do this as necessary, jsdom doesn't.
node.value = '' + value;
} If the input has the default of I'm not sure how we can address this just yet. We may have to do string-based comparisons on top of the existing check to determine if there are other cases like this where the |
This is really tricky. It looks like the standard browser behavior is to allow In Chrome, the number input reports values as follows:
So it's tough, but I think there's something to doing a string comparison for left-hand zeroes. @aweary I'd be happy to help dig into this. Or at least please let me know if I can answer any questions. |
@nhunzaker I've got some work towards this locally so I'm happy to keep working on it. I'm hoping we could avoid relying on string comparisons but it's looking like the only way to fix this soundly 🤔 |
@aweary I'm trying to fix this issue, looks like the
However, I couldn't see anywhere we are parsing it to the Number like you have said above (like
where the |
@antoaravinth Just for some background, there was a change in December of last year: Parsing was removed, because we don't need it. A loose equality check (with some guards) is sufficient, because it parses string values into numbers for comparison. |
@nhunzaker Thanks. I had found a way to fix this issue, the block of code now looks like the following:
I would say this handles the case and fix the issue. No other test cases got failed and the issue was resolved. Yes, it sounds bit hacky, but I saw similar check was added for handling changes on |
Interesting. It might be a bit hacky, but, given what some browsers give us to work with, it's the situation we're in. This might be unit testable. I'd like to take these next steps:
|
@nhunzaker Sure, will do that. Actually I have done the browser testing. After this change, ran build and used the dist version of react.js and seems to be working fine with chrome. May be will test in other browsers also and update/create new test cases. |
Awesome. Just to make sure it's surfaced, our DOM Test Fixtures are here: We have a section specifically for number inputs, if that helps testing. Once we move forward on a fix, my plan is to test it against those fixtures. @antoaravinth: do you mind if I assign you on this issue? |
@nhunzaker Never mind, you can assign me the issue. Will get it done :) |
Ah I can't assign you formally. But consider it yours. |
@nhunzaker Sure, thanks! |
Just checking in! No rush on progress, but anything I can do to help move things along? |
@nhuzaker: Hey, here is the update:
For the above two points, I guess its taken care. After the change, I ran a sample app against the build and the issue is fixed (tested in chrome and firefox). I will write a unit test case for the same, so that we have test in place for this use case and raise a PR. What say? Sorry for the delay btw. Mostly will close this by weekend. |
No need to apologize! Thanks for the update! |
@antoaravinth's fix in #12451 definitely addresses the concern of this issue. However I didn't fully understand the ramifications of this change until I tried it for myself: Change in behaviorBeforeNumber inputs respect values if they parse to the same numeric value. So AfterNumber inputs always use the reduced value. So if you typed ConcernsThis change makes it easier to control the absolute value sent into a number input, but I am concerned that it results in a confusing user experience. The key strokes a user enters into a text box do not align with what they see on the screen. Additionally, number inputs do not give us a text selection API, causing text selection to jump very easily. For example: Deleting the leading zero in
Inserting a number before the decimal place on
So what do we do?Personally, I think we should optimize for avoiding character deletion while the user is typing. It might be possible that we could apply this behavior only when the number input is not in focus. That would allow you greater control over the value if changing it outside of user text entry, while avoiding confusion during typing. What do you think? |
Doesn't seem like facebook/react#9402 will be fixed any time soon, so we'll work around it for now.
Doesn't seem like facebook/react#9402 will be fixed any time soon, so we'll work around it for now.
Something similar happens with I've noticed it's already been referenced here too but as far as I know it hasn't been fixed so if somebody is still looking for a quick solution that doesn't have to parse through the value, I've fixed it for integers by interpreting an empty string in the view as 0 in the model (and vice versa): <input type="number" value={this.state.value || ''} onChange={this.handle.bind(this)} /> Although it's still possible to have leading zeros this way when you try hard (first typing non-zeros and then typing leading zeros), that's not a real issue with integers. The number is saved correctly as long as it can be parsed by parseInt otherwise it's saved as |
Hi guys, any updates about this issue? I am testing in Google Chrome and I still cannot delete the 0. Once I change the focus from the numeric input the state of the application is updated to 0. If I type more numbers to the right of the 0 the number is saved as the integers > 0 that I entered, but the numeric input still shows the number with a 0 preceding, which is confusing for the user. |
I change |
My solution to this is now quite simple:
In the onChange-handler, I make sure, to update my source object property (SampleFormData.myNumberProperty) with a number-type. With this approach I am in total control: |
see react github issue page: facebook/react#9402
This problem is reported in the following Facebook post: facebook/react#9402
commit e704c4c Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 15 06:05:46 2024 -0300 chore: update package version to 1.0.0 commit ed203b7 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Aug 14 08:42:23 2024 -0300 feat: disable input and buttons This ensures that the user cannot add a new task while another one is in progress. commit 3d62686 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Aug 14 08:35:38 2024 -0300 feat: adds toasts to the user commit 53040c0 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Aug 14 07:06:32 2024 -0300 refactor: converts task state update logic to use a reducer therefore, it was necessary to change all the places that referenced the previous logic. commit b32fcee Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Aug 12 06:39:24 2024 -0300 fix: bug when trying to get invalid tasks from memory commit cb530ad Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Aug 12 06:16:27 2024 -0300 feat: show saved tasks in suggestions commit 41e9dc6 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 10 13:44:27 2024 -0300 fix: bug that showed wrong time when changing screen commit 025f413 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 10 12:44:46 2024 -0300 fix: multiple tasks with ongoing status commit ef18fdf Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 10 12:22:24 2024 -0300 feat: saves tasks in memory commit ffce8ef Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 10 10:21:02 2024 -0300 fix: table information styles commit 569a27e Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 10 10:14:50 2024 -0300 fix: duplicate tasks bug commit 4c1e1f5 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 10 09:36:09 2024 -0300 feat: shows existing tasks in history commit a4a7ad4 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 9 08:15:46 2024 -0300 fix: adds typing required for countdown commit e9ce9d3 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 9 08:09:03 2024 -0300 refactor: routine to create a task Therefore, it was necessary to increase typing and adjust the locations that used them. commit ddd0e92 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 9 07:11:22 2024 -0300 refactor: time segmentation With this, the logic becomes interconnected, that is, the seconds to be shown will be explicitly dependent on the minutes. commit 6f89051 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 8 08:29:53 2024 -0300 feat: add the functionality to finish the task This should occur when the desired time is up. commit c753a97 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 8 08:10:51 2024 -0300 refactor: remove unnecessary logic commit ade1140 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 8 07:36:58 2024 -0300 fix: problem of not showing the initial time commit fcc51c4 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 8 06:21:16 2024 -0300 refactor: isolates the countdown logic in a hook commit b0733dd Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 8 06:12:05 2024 -0300 chore: adds a file to specify the node version commit a334859 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 8 06:10:29 2024 -0300 feat: adds the functionality to stop the countdown commit fe4bc48 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Aug 5 07:39:44 2024 -0300 fix: lint issues commit aea8d9f Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Aug 5 07:28:54 2024 -0300 chore: remove unnecessary aliases commit af990b0 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Aug 5 07:17:13 2024 -0300 feat: adds a favicon to the application commit fe4a9b4 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Aug 5 07:05:08 2024 -0300 feat: add logic to clear timeout With this, the counter logic will not be executed when the component is unmounted. commit d66450b Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sun Aug 4 17:03:02 2024 -0300 feat: adds countdown functionality commit e147d78 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 2 16:50:04 2024 -0300 fix: wip3 - adds functionality to start the counter prevents the countdown from being rendered every time any form input changes commit 42b1326 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 2 12:31:08 2024 -0300 refactor: rename the state to be more meaningful commit d0a421c Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 2 12:22:38 2024 -0300 refactor: transports the state to the context This made it necessary to make the task type and its utilities global, having to change everyone who used them. commit 37d88e3 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 2 10:45:34 2024 -0300 feat: wip2 - adds functionality to start the counter creates the context that will be used in the future to handle tasks commit 6dcfefd Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 1 08:32:15 2024 -0300 feat(home/hook.ts): wip - adds functionality to start the counter commit c3928bf Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 29 07:17:30 2024 -0300 ci: add the dependencies file commit b019e15 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 29 07:05:17 2024 -0300 refactor: separates numbers into a component commit a8f7203 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 27 13:56:14 2024 -0300 refactor: bug of adding wrong numbers For example, if a user adds numbers like "1.", "2.", "3.", the data would be invalid. commit a80d44a Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 27 13:53:40 2024 -0300 feat: add logic to enable or disable the StartStopButton commit 40bbab4 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 27 13:06:40 2024 -0300 refactor: leaving names and logic more concise commit bee5454 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 27 10:21:34 2024 -0300 feat: add title to buttons commit 0e478bf Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 27 10:15:41 2024 -0300 refactor: the logic of registering form fields commit cc18914 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 27 09:55:25 2024 -0300 feat: integrates the form with zod and react hook form commit 4fc16e2 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Jul 25 06:30:23 2024 -0300 refactor: changes the StartStopButton component to its place commit 1016500 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Jul 25 06:18:38 2024 -0300 chore: changes the development flow commit d0576f7 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 24 08:48:37 2024 -0300 refactor: use aliases in imports commit 06afc64 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 24 08:42:51 2024 -0300 style: adds settings for import aliases commit f3d4a85 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 22 08:33:59 2024 -0300 refactor: add more meaningful names for functions commit 9844ca5 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 22 08:24:38 2024 -0300 feat: adds function to ensure minimum time commit 938ad96 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 22 08:14:03 2024 -0300 fix: glitch that allows you to add letters to the desired time field commit f51e202 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 22 07:25:45 2024 -0300 fix: visual bug in the desired time input Now, when starting the application, the placeholder text is shown to the user. commit 36178a0 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 22 07:18:26 2024 -0300 fix: problem with a zero appearing on the left This problem is reported in the following Facebook post: facebook/react#9402 commit 711596f Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 20 11:59:11 2024 -0300 feat: adds functionality to time buttons commit 9e6d44b Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 20 10:22:07 2024 -0300 feat: add styles to table rows commit 0d48466 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 20 10:11:57 2024 -0300 fix: the visible height of the table container commit 3d0661b Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Jul 19 11:12:10 2024 -0300 feat: adds styles for when there are no tasks commit 9ec2d43 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Jul 19 09:24:16 2024 -0300 fix: cell text styles commit fd64d91 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Jul 19 09:14:57 2024 -0300 feat: add colors to statuses commit e7351b4 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Jul 18 07:08:22 2024 -0300 feat: adds a list of suggestions to the input commit 8c9e271 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Jul 18 06:34:50 2024 -0300 refactor: isolates the home button logic in a component commit 83e85d2 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 08:51:51 2024 -0300 refactor: start and pause buttons commit 6875f9d Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 08:48:29 2024 -0300 feat: add more styles for buttons and anchors commit baae09b Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 07:41:38 2024 -0300 fix: start and stop button icon styles commit 645d6bf Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 07:16:33 2024 -0300 feat: change global styles for buttons and anchors commit 866a992 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 06:44:41 2024 -0300 feat: add a tooltip for the play button commit 7fa7adb Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 06:43:26 2024 -0300 refactor: elevates the tooltip styles to the body commit 85cd0b6 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 06:19:06 2024 -0300 fix: tooltip styles commit 428d624 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 08:49:40 2024 -0300 fix: adjust the style of the history page commit 0686597 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 08:44:38 2024 -0300 fix: task name input color commit d6eecc4 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 08:14:16 2024 -0300 chore: change lint rules commit 16c5e4e Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 08:03:53 2024 -0300 fix: adds typing to the styles component commit e1a5016 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 07:43:52 2024 -0300 chore: modifies the Developer Experience commit 7df728c Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 07:41:20 2024 -0300 refactor: isolates routing logic commit 4800d5b Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 07:29:37 2024 -0300 refactor: isolates general style logic commit ac9418b Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 13 14:06:36 2024 -0300 feat: add styles to header links commit 1042df9 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 13 12:30:00 2024 -0300 fix: content container styles commit 73742f5 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 13 11:21:37 2024 -0300 ci: change hook file permissions commit 524d5c3 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 13 11:18:29 2024 -0300 build: change the package manager commit ebec772 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 13 11:14:47 2024 -0300 fix: customSimpleBar styles Therefore, the spacing and sizes will follow the proposed layout. commit 06ee7bb Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 25 00:57:44 2023 -0300 refactor: isolates the CustomSimpleBar in a component commit 3aa055c Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 25 00:25:54 2023 -0300 feat: add History page responsiveness commit 323acdb Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 24 00:18:23 2023 -0300 feat: starts creating the history page commit 43d57e3 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Aug 23 01:02:58 2023 -0300 refactor: improves home page responsiveness commit dc16f7f Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 19 13:55:56 2023 -0300 feat: create the DefaultLayout commit a7ef386 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Aug 9 22:35:21 2023 -0300 refactor: remakes the way icons are styled commit 7493e63 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 5 15:36:50 2023 -0300 feat: makes the home page responsive commit bfb22c6 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 5 00:25:31 2023 -0300 feat: makes the styles of the buttons play and stop commit 5475bee Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 4 23:57:41 2023 -0300 feat: makes the style of numbers commit d97c9e0 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 4 23:19:12 2023 -0300 feat: start the styles of the form commit 92bf762 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 3 00:38:16 2023 -0300 feat: does the initial styling of the Header commit 0602667 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 29 13:54:07 2023 -0300 feat: creates the general styles of the application commit fa30d41 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 29 12:33:00 2023 -0300 feat: adds linters and a workflow
Squashed commit of the following: commit e704c4c Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 15 06:05:46 2024 -0300 chore: update package version to 1.0.0 commit ed203b7 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Aug 14 08:42:23 2024 -0300 feat: disable input and buttons This ensures that the user cannot add a new task while another one is in progress. commit 3d62686 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Aug 14 08:35:38 2024 -0300 feat: adds toasts to the user commit 53040c0 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Aug 14 07:06:32 2024 -0300 refactor: converts task state update logic to use a reducer therefore, it was necessary to change all the places that referenced the previous logic. commit b32fcee Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Aug 12 06:39:24 2024 -0300 fix: bug when trying to get invalid tasks from memory commit cb530ad Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Aug 12 06:16:27 2024 -0300 feat: show saved tasks in suggestions commit 41e9dc6 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 10 13:44:27 2024 -0300 fix: bug that showed wrong time when changing screen commit 025f413 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 10 12:44:46 2024 -0300 fix: multiple tasks with ongoing status commit ef18fdf Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 10 12:22:24 2024 -0300 feat: saves tasks in memory commit ffce8ef Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 10 10:21:02 2024 -0300 fix: table information styles commit 569a27e Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 10 10:14:50 2024 -0300 fix: duplicate tasks bug commit 4c1e1f5 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 10 09:36:09 2024 -0300 feat: shows existing tasks in history commit a4a7ad4 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 9 08:15:46 2024 -0300 fix: adds typing required for countdown commit e9ce9d3 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 9 08:09:03 2024 -0300 refactor: routine to create a task Therefore, it was necessary to increase typing and adjust the locations that used them. commit ddd0e92 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 9 07:11:22 2024 -0300 refactor: time segmentation With this, the logic becomes interconnected, that is, the seconds to be shown will be explicitly dependent on the minutes. commit 6f89051 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 8 08:29:53 2024 -0300 feat: add the functionality to finish the task This should occur when the desired time is up. commit c753a97 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 8 08:10:51 2024 -0300 refactor: remove unnecessary logic commit ade1140 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 8 07:36:58 2024 -0300 fix: problem of not showing the initial time commit fcc51c4 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 8 06:21:16 2024 -0300 refactor: isolates the countdown logic in a hook commit b0733dd Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 8 06:12:05 2024 -0300 chore: adds a file to specify the node version commit a334859 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 8 06:10:29 2024 -0300 feat: adds the functionality to stop the countdown commit fe4bc48 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Aug 5 07:39:44 2024 -0300 fix: lint issues commit aea8d9f Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Aug 5 07:28:54 2024 -0300 chore: remove unnecessary aliases commit af990b0 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Aug 5 07:17:13 2024 -0300 feat: adds a favicon to the application commit fe4a9b4 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Aug 5 07:05:08 2024 -0300 feat: add logic to clear timeout With this, the counter logic will not be executed when the component is unmounted. commit d66450b Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sun Aug 4 17:03:02 2024 -0300 feat: adds countdown functionality commit e147d78 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 2 16:50:04 2024 -0300 fix: wip3 - adds functionality to start the counter prevents the countdown from being rendered every time any form input changes commit 42b1326 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 2 12:31:08 2024 -0300 refactor: rename the state to be more meaningful commit d0a421c Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 2 12:22:38 2024 -0300 refactor: transports the state to the context This made it necessary to make the task type and its utilities global, having to change everyone who used them. commit 37d88e3 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 2 10:45:34 2024 -0300 feat: wip2 - adds functionality to start the counter creates the context that will be used in the future to handle tasks commit 6dcfefd Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 1 08:32:15 2024 -0300 feat(home/hook.ts): wip - adds functionality to start the counter commit c3928bf Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 29 07:17:30 2024 -0300 ci: add the dependencies file commit b019e15 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 29 07:05:17 2024 -0300 refactor: separates numbers into a component commit a8f7203 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 27 13:56:14 2024 -0300 refactor: bug of adding wrong numbers For example, if a user adds numbers like "1.", "2.", "3.", the data would be invalid. commit a80d44a Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 27 13:53:40 2024 -0300 feat: add logic to enable or disable the StartStopButton commit 40bbab4 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 27 13:06:40 2024 -0300 refactor: leaving names and logic more concise commit bee5454 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 27 10:21:34 2024 -0300 feat: add title to buttons commit 0e478bf Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 27 10:15:41 2024 -0300 refactor: the logic of registering form fields commit cc18914 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 27 09:55:25 2024 -0300 feat: integrates the form with zod and react hook form commit 4fc16e2 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Jul 25 06:30:23 2024 -0300 refactor: changes the StartStopButton component to its place commit 1016500 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Jul 25 06:18:38 2024 -0300 chore: changes the development flow commit d0576f7 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 24 08:48:37 2024 -0300 refactor: use aliases in imports commit 06afc64 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 24 08:42:51 2024 -0300 style: adds settings for import aliases commit f3d4a85 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 22 08:33:59 2024 -0300 refactor: add more meaningful names for functions commit 9844ca5 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 22 08:24:38 2024 -0300 feat: adds function to ensure minimum time commit 938ad96 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 22 08:14:03 2024 -0300 fix: glitch that allows you to add letters to the desired time field commit f51e202 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 22 07:25:45 2024 -0300 fix: visual bug in the desired time input Now, when starting the application, the placeholder text is shown to the user. commit 36178a0 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 22 07:18:26 2024 -0300 fix: problem with a zero appearing on the left This problem is reported in the following Facebook post: facebook/react#9402 commit 711596f Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 20 11:59:11 2024 -0300 feat: adds functionality to time buttons commit 9e6d44b Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 20 10:22:07 2024 -0300 feat: add styles to table rows commit 0d48466 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 20 10:11:57 2024 -0300 fix: the visible height of the table container commit 3d0661b Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Jul 19 11:12:10 2024 -0300 feat: adds styles for when there are no tasks commit 9ec2d43 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Jul 19 09:24:16 2024 -0300 fix: cell text styles commit fd64d91 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Jul 19 09:14:57 2024 -0300 feat: add colors to statuses commit e7351b4 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Jul 18 07:08:22 2024 -0300 feat: adds a list of suggestions to the input commit 8c9e271 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Jul 18 06:34:50 2024 -0300 refactor: isolates the home button logic in a component commit 83e85d2 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 08:51:51 2024 -0300 refactor: start and pause buttons commit 6875f9d Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 08:48:29 2024 -0300 feat: add more styles for buttons and anchors commit baae09b Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 07:41:38 2024 -0300 fix: start and stop button icon styles commit 645d6bf Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 07:16:33 2024 -0300 feat: change global styles for buttons and anchors commit 866a992 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 06:44:41 2024 -0300 feat: add a tooltip for the play button commit 7fa7adb Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 06:43:26 2024 -0300 refactor: elevates the tooltip styles to the body commit 85cd0b6 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 06:19:06 2024 -0300 fix: tooltip styles commit 428d624 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 08:49:40 2024 -0300 fix: adjust the style of the history page commit 0686597 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 08:44:38 2024 -0300 fix: task name input color commit d6eecc4 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 08:14:16 2024 -0300 chore: change lint rules commit 16c5e4e Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 08:03:53 2024 -0300 fix: adds typing to the styles component commit e1a5016 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 07:43:52 2024 -0300 chore: modifies the Developer Experience commit 7df728c Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 07:41:20 2024 -0300 refactor: isolates routing logic commit 4800d5b Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 07:29:37 2024 -0300 refactor: isolates general style logic commit ac9418b Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 13 14:06:36 2024 -0300 feat: add styles to header links commit 1042df9 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 13 12:30:00 2024 -0300 fix: content container styles commit 73742f5 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 13 11:21:37 2024 -0300 ci: change hook file permissions commit 524d5c3 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 13 11:18:29 2024 -0300 build: change the package manager commit ebec772 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 13 11:14:47 2024 -0300 fix: customSimpleBar styles Therefore, the spacing and sizes will follow the proposed layout. commit 06ee7bb Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 25 00:57:44 2023 -0300 refactor: isolates the CustomSimpleBar in a component commit 3aa055c Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 25 00:25:54 2023 -0300 feat: add History page responsiveness commit 323acdb Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 24 00:18:23 2023 -0300 feat: starts creating the history page commit 43d57e3 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Aug 23 01:02:58 2023 -0300 refactor: improves home page responsiveness commit dc16f7f Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 19 13:55:56 2023 -0300 feat: create the DefaultLayout commit a7ef386 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Aug 9 22:35:21 2023 -0300 refactor: remakes the way icons are styled commit 7493e63 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 5 15:36:50 2023 -0300 feat: makes the home page responsive commit bfb22c6 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 5 00:25:31 2023 -0300 feat: makes the styles of the buttons play and stop commit 5475bee Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 4 23:57:41 2023 -0300 feat: makes the style of numbers commit d97c9e0 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 4 23:19:12 2023 -0300 feat: start the styles of the form commit 92bf762 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 3 00:38:16 2023 -0300 feat: does the initial styling of the Header commit 0602667 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 29 13:54:07 2023 -0300 feat: creates the general styles of the application commit fa30d41 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 29 12:33:00 2023 -0300 feat: adds linters and a workflow
Squashed commit of the following: commit d0e6f2a6685b35a674637106c3b6b03f9a9d5e26 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 15 08:28:54 2024 -0300 docs: add information to readme commit a45bfa5 Merge: e704c4c 50cc8a0 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 15 07:20:52 2024 -0300 Merge branch 'main' of https://github.com/devgustavosantos/ignite-timer into develop commit e704c4c Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 15 06:05:46 2024 -0300 chore: update package version to 1.0.0 commit ed203b7 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Aug 14 08:42:23 2024 -0300 feat: disable input and buttons This ensures that the user cannot add a new task while another one is in progress. commit 3d62686 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Aug 14 08:35:38 2024 -0300 feat: adds toasts to the user commit 53040c0 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Aug 14 07:06:32 2024 -0300 refactor: converts task state update logic to use a reducer therefore, it was necessary to change all the places that referenced the previous logic. commit b32fcee Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Aug 12 06:39:24 2024 -0300 fix: bug when trying to get invalid tasks from memory commit cb530ad Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Aug 12 06:16:27 2024 -0300 feat: show saved tasks in suggestions commit 41e9dc6 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 10 13:44:27 2024 -0300 fix: bug that showed wrong time when changing screen commit 025f413 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 10 12:44:46 2024 -0300 fix: multiple tasks with ongoing status commit ef18fdf Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 10 12:22:24 2024 -0300 feat: saves tasks in memory commit ffce8ef Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 10 10:21:02 2024 -0300 fix: table information styles commit 569a27e Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 10 10:14:50 2024 -0300 fix: duplicate tasks bug commit 4c1e1f5 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 10 09:36:09 2024 -0300 feat: shows existing tasks in history commit a4a7ad4 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 9 08:15:46 2024 -0300 fix: adds typing required for countdown commit e9ce9d3 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 9 08:09:03 2024 -0300 refactor: routine to create a task Therefore, it was necessary to increase typing and adjust the locations that used them. commit ddd0e92 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 9 07:11:22 2024 -0300 refactor: time segmentation With this, the logic becomes interconnected, that is, the seconds to be shown will be explicitly dependent on the minutes. commit 6f89051 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 8 08:29:53 2024 -0300 feat: add the functionality to finish the task This should occur when the desired time is up. commit c753a97 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 8 08:10:51 2024 -0300 refactor: remove unnecessary logic commit ade1140 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 8 07:36:58 2024 -0300 fix: problem of not showing the initial time commit fcc51c4 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 8 06:21:16 2024 -0300 refactor: isolates the countdown logic in a hook commit b0733dd Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 8 06:12:05 2024 -0300 chore: adds a file to specify the node version commit a334859 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 8 06:10:29 2024 -0300 feat: adds the functionality to stop the countdown commit fe4bc48 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Aug 5 07:39:44 2024 -0300 fix: lint issues commit aea8d9f Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Aug 5 07:28:54 2024 -0300 chore: remove unnecessary aliases commit af990b0 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Aug 5 07:17:13 2024 -0300 feat: adds a favicon to the application commit fe4a9b4 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Aug 5 07:05:08 2024 -0300 feat: add logic to clear timeout With this, the counter logic will not be executed when the component is unmounted. commit d66450b Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sun Aug 4 17:03:02 2024 -0300 feat: adds countdown functionality commit e147d78 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 2 16:50:04 2024 -0300 fix: wip3 - adds functionality to start the counter prevents the countdown from being rendered every time any form input changes commit 42b1326 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 2 12:31:08 2024 -0300 refactor: rename the state to be more meaningful commit d0a421c Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 2 12:22:38 2024 -0300 refactor: transports the state to the context This made it necessary to make the task type and its utilities global, having to change everyone who used them. commit 37d88e3 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 2 10:45:34 2024 -0300 feat: wip2 - adds functionality to start the counter creates the context that will be used in the future to handle tasks commit 6dcfefd Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 1 08:32:15 2024 -0300 feat(home/hook.ts): wip - adds functionality to start the counter commit c3928bf Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 29 07:17:30 2024 -0300 ci: add the dependencies file commit b019e15 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 29 07:05:17 2024 -0300 refactor: separates numbers into a component commit a8f7203 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 27 13:56:14 2024 -0300 refactor: bug of adding wrong numbers For example, if a user adds numbers like "1.", "2.", "3.", the data would be invalid. commit a80d44a Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 27 13:53:40 2024 -0300 feat: add logic to enable or disable the StartStopButton commit 40bbab4 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 27 13:06:40 2024 -0300 refactor: leaving names and logic more concise commit bee5454 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 27 10:21:34 2024 -0300 feat: add title to buttons commit 0e478bf Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 27 10:15:41 2024 -0300 refactor: the logic of registering form fields commit cc18914 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 27 09:55:25 2024 -0300 feat: integrates the form with zod and react hook form commit 4fc16e2 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Jul 25 06:30:23 2024 -0300 refactor: changes the StartStopButton component to its place commit 1016500 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Jul 25 06:18:38 2024 -0300 chore: changes the development flow commit d0576f7 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 24 08:48:37 2024 -0300 refactor: use aliases in imports commit 06afc64 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 24 08:42:51 2024 -0300 style: adds settings for import aliases commit f3d4a85 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 22 08:33:59 2024 -0300 refactor: add more meaningful names for functions commit 9844ca5 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 22 08:24:38 2024 -0300 feat: adds function to ensure minimum time commit 938ad96 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 22 08:14:03 2024 -0300 fix: glitch that allows you to add letters to the desired time field commit f51e202 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 22 07:25:45 2024 -0300 fix: visual bug in the desired time input Now, when starting the application, the placeholder text is shown to the user. commit 36178a0 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 22 07:18:26 2024 -0300 fix: problem with a zero appearing on the left This problem is reported in the following Facebook post: facebook/react#9402 commit 711596f Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 20 11:59:11 2024 -0300 feat: adds functionality to time buttons commit 9e6d44b Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 20 10:22:07 2024 -0300 feat: add styles to table rows commit 0d48466 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 20 10:11:57 2024 -0300 fix: the visible height of the table container commit 3d0661b Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Jul 19 11:12:10 2024 -0300 feat: adds styles for when there are no tasks commit 9ec2d43 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Jul 19 09:24:16 2024 -0300 fix: cell text styles commit fd64d91 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Jul 19 09:14:57 2024 -0300 feat: add colors to statuses commit e7351b4 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Jul 18 07:08:22 2024 -0300 feat: adds a list of suggestions to the input commit 8c9e271 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Jul 18 06:34:50 2024 -0300 refactor: isolates the home button logic in a component commit 83e85d2 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 08:51:51 2024 -0300 refactor: start and pause buttons commit 6875f9d Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 08:48:29 2024 -0300 feat: add more styles for buttons and anchors commit baae09b Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 07:41:38 2024 -0300 fix: start and stop button icon styles commit 645d6bf Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 07:16:33 2024 -0300 feat: change global styles for buttons and anchors commit 866a992 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 06:44:41 2024 -0300 feat: add a tooltip for the play button commit 7fa7adb Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 06:43:26 2024 -0300 refactor: elevates the tooltip styles to the body commit 85cd0b6 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Jul 17 06:19:06 2024 -0300 fix: tooltip styles commit 428d624 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 08:49:40 2024 -0300 fix: adjust the style of the history page commit 0686597 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 08:44:38 2024 -0300 fix: task name input color commit d6eecc4 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 08:14:16 2024 -0300 chore: change lint rules commit 16c5e4e Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 08:03:53 2024 -0300 fix: adds typing to the styles component commit e1a5016 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 07:43:52 2024 -0300 chore: modifies the Developer Experience commit 7df728c Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 07:41:20 2024 -0300 refactor: isolates routing logic commit 4800d5b Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Mon Jul 15 07:29:37 2024 -0300 refactor: isolates general style logic commit ac9418b Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 13 14:06:36 2024 -0300 feat: add styles to header links commit 1042df9 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 13 12:30:00 2024 -0300 fix: content container styles commit 73742f5 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 13 11:21:37 2024 -0300 ci: change hook file permissions commit 524d5c3 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 13 11:18:29 2024 -0300 build: change the package manager commit ebec772 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 13 11:14:47 2024 -0300 fix: customSimpleBar styles Therefore, the spacing and sizes will follow the proposed layout. commit 06ee7bb Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 25 00:57:44 2023 -0300 refactor: isolates the CustomSimpleBar in a component commit 3aa055c Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 25 00:25:54 2023 -0300 feat: add History page responsiveness commit 323acdb Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 24 00:18:23 2023 -0300 feat: starts creating the history page commit 43d57e3 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Aug 23 01:02:58 2023 -0300 refactor: improves home page responsiveness commit dc16f7f Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 19 13:55:56 2023 -0300 feat: create the DefaultLayout commit a7ef386 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Wed Aug 9 22:35:21 2023 -0300 refactor: remakes the way icons are styled commit 7493e63 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 5 15:36:50 2023 -0300 feat: makes the home page responsive commit bfb22c6 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Aug 5 00:25:31 2023 -0300 feat: makes the styles of the buttons play and stop commit 5475bee Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 4 23:57:41 2023 -0300 feat: makes the style of numbers commit d97c9e0 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Fri Aug 4 23:19:12 2023 -0300 feat: start the styles of the form commit 92bf762 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Thu Aug 3 00:38:16 2023 -0300 feat: does the initial styling of the Header commit 0602667 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 29 13:54:07 2023 -0300 feat: creates the general styles of the application commit fa30d41 Author: Gustavo Santos <devgustavosantos@gmail.com> Date: Sat Jul 29 12:33:00 2023 -0300 feat: adds linters and a workflow
Do you want to request a feature or report a bug?
bug
What is the current behavior?
I have a number input with defalut value 0 and in onChange function I'll parse value to float to avoid invalid input, but I'll always get left pad 0 on input UI. But in previouse version, my code works.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/84v837e9/).
<input type="number" value={this.state.value} onChange={e=>this.setState({value: parseFloat(e.target.value)? parseFloat(e.target.value) : 0})}
What is the expected behavior?
Should not have left pad 0.
Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
react 15.5.3, all browser / all OS. It works in 15.4.2
The text was updated successfully, but these errors were encountered: