Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when navigating away from screens #46559

Closed
wants to merge 1 commit into from
Closed

Fix crash when navigating away from screens #46559

wants to merge 1 commit into from
+8 −1

Commits on Sep 19, 2024

  1. Fix crash when navigating away from screens (facebook#46559) 

    Summary:
Pull Request resolved: facebook#46559

There is an edge case when we navigate away from a screen that contains a scroll view where one of the UISCrollViewDelegates does not implement the scrollViewDidEndDecelerating method.

This happens because the Macro used assumes that the event that we are forwarding is the actual method from where the macro is called. Which is not true when it comes to `didMoveToWindow`.

This change fixes that by explicitly expanding the macro in this scenario and passing the right selector.

## Changelog:
[iOS][Fixed] - Fixed a crash when navigating away from a screen that contains a scrollView

## Facebook
This should fix T201780472

Reviewed By: philIip

Differential Revision: D62935876
    @cipolleschi @facebook-github-bot
    cipolleschi authored and facebook-github-bot committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    51c0d08 View commit details
    Browse the repository at this point in the history