Fix crash when navigating away from screens #46559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62935876 |
|
This pull request was exported from Phabricator. Differential Revision: D62935876 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 18, 2024
Summary: Pull Request resolved: facebook#46559 There is an edge case when we navigate away from a screen that contains a scroll view where one of the UISCrollViewDelegates does not implement the scrollViewDidEndDecelerating method. This happens because the Macro used assumes that the event that we are forwarding is the actual method from where the macro is called. Which is not true when it comes to `didMoveToWindow`. This change fixes that by explicitly expanding the macro in this scenario and passing the right selector. ## Changelog: [iOS][Fixed] - Fixed a crash when navigating away from a screen that contains a scrollView ## Facebook This should fix T201780472 Differential Revision: D62935876
cipolleschi
force-pushed
the
export-D62935876
branch
from
f4d3419
to
0ef860a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62935876 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 18, 2024
Summary: Pull Request resolved: facebook#46559 There is an edge case when we navigate away from a screen that contains a scroll view where one of the UISCrollViewDelegates does not implement the scrollViewDidEndDecelerating method. This happens because the Macro used assumes that the event that we are forwarding is the actual method from where the macro is called. Which is not true when it comes to `didMoveToWindow`. This change fixes that by explicitly expanding the macro in this scenario and passing the right selector. ## Changelog: [iOS][Fixed] - Fixed a crash when navigating away from a screen that contains a scrollView ## Facebook This should fix T201780472 Differential Revision: D62935876
cipolleschi
force-pushed
the
export-D62935876
branch
from
0ef860a
to
4be15a1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62935876 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 18, 2024
Summary: Pull Request resolved: facebook#46559 There is an edge case when we navigate away from a screen that contains a scroll view where one of the UISCrollViewDelegates does not implement the scrollViewDidEndDecelerating method. This happens because the Macro used assumes that the event that we are forwarding is the actual method from where the macro is called. Which is not true when it comes to `didMoveToWindow`. This change fixes that by explicitly expanding the macro in this scenario and passing the right selector. ## Changelog: [iOS][Fixed] - Fixed a crash when navigating away from a screen that contains a scrollView ## Facebook This should fix T201780472 Differential Revision: D62935876
cipolleschi
force-pushed
the
export-D62935876
branch
from
4be15a1
to
c31f08b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62935876 |
cipolleschi
force-pushed
the
export-D62935876
branch
from
c31f08b
to
31fc126
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 19, 2024
Summary: Pull Request resolved: facebook#46559 There is an edge case when we navigate away from a screen that contains a scroll view where one of the UISCrollViewDelegates does not implement the scrollViewDidEndDecelerating method. This happens because the Macro used assumes that the event that we are forwarding is the actual method from where the macro is called. Which is not true when it comes to `didMoveToWindow`. This change fixes that by explicitly expanding the macro in this scenario and passing the right selector. ## Changelog: [iOS][Fixed] - Fixed a crash when navigating away from a screen that contains a scrollView ## Facebook This should fix T201780472 Reviewed By: philIip Differential Revision: D62935876
Summary: Pull Request resolved: facebook#46559 There is an edge case when we navigate away from a screen that contains a scroll view where one of the UISCrollViewDelegates does not implement the scrollViewDidEndDecelerating method. This happens because the Macro used assumes that the event that we are forwarding is the actual method from where the macro is called. Which is not true when it comes to `didMoveToWindow`. This change fixes that by explicitly expanding the macro in this scenario and passing the right selector. ## Changelog: [iOS][Fixed] - Fixed a crash when navigating away from a screen that contains a scrollView ## Facebook This should fix T201780472 Reviewed By: philIip Differential Revision: D62935876
|
This pull request was exported from Phabricator. Differential Revision: D62935876 |
cipolleschi
force-pushed
the
export-D62935876
branch
from
31fc126
to
51c0d08
Compare
|
This pull request has been merged in c6f3282. |
|
This pull request was successfully merged by @cipolleschi in c6f3282 When will my fix make it into a release? | How to file a pick request? |
blakef
pushed a commit
that referenced
this pull request
Sep 23, 2024
Summary: Pull Request resolved: #46559 There is an edge case when we navigate away from a screen that contains a scroll view where one of the UISCrollViewDelegates does not implement the scrollViewDidEndDecelerating method. This happens because the Macro used assumes that the event that we are forwarding is the actual method from where the macro is called. Which is not true when it comes to `didMoveToWindow`. This change fixes that by explicitly expanding the macro in this scenario and passing the right selector. ## Changelog: [iOS][Fixed] - Fixed a crash when navigating away from a screen that contains a scrollView ## Facebook This should fix T201780472 Reviewed By: philIip Differential Revision: D62935876 fbshipit-source-id: e29aadf201c8066b5d3b7b0ada21fa8d763e9af0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There is an edge case when we navigate away from a screen that contains a scroll view where one of the UISCrollViewDelegates does not implement the scrollViewDidEndDecelerating method.
This happens because the Macro used assumes that the event that we are forwarding is the actual method from where the macro is called. Which is not true when it comes to
didMoveToWindow.This change fixes that by explicitly expanding the macro in this scenario and passing the right selector.
Changelog:
[iOS][Fixed] - Fixed a crash when navigating away from a screen that contains a scrollView
Facebook
This should fix T201780472
Differential Revision: D62935876