Fix text baseline being moved up on iOS

[j-piasecki]

Summary:

Fixes #44929

Moves calling RCTApplyBaselineOffset so it's called in similar way as on the old architecture:

react-native/packages/react-native/Libraries/Text/Text/RCTTextShadowView.mm

Line 229 in 726a4a1

[self postprocessAttributedText:textStorage];

react-native/packages/react-native/Libraries/Text/Text/RCTTextShadowView.mm

Lines 165 to 167 in 726a4a1

	[attributedText addAttribute:NSBaselineOffsetAttributeName
	value:@(baseLineOffset)
	range:NSMakeRange(0, attributedText.length)];

I'm not exactly sure why (and Apple's docs aren't helping) but it looks like calling NSTextStorage initWithAttributedString results in an attributed string where emojis are separate fragments with Apple's emoji font set, which results in the correct baseline calculations. This is the way it happens on the old arch.

The way it's currently implemented on the new architecture, RCTApplyBaselineOffset is called on ` newly created attributed string where emojis are in the same fragment as other parts of the text which alters the result of baseline calculations compared to what's later drawn on the screen.

Changelog:

[IOS] [FIXED] - Fixed text baseline being moved upwards in certain cases

Test Plan:

Check the following snipped

import React from 'react';
import {
  Text,
  View,
} from 'react-native';

const App = () => {
  return (
    <View style={{
      paddingTop: 100,
    }}>
        <Text style={{fontSize: 15, lineHeight: 20, fontFamily: 'Arial', backgroundColor: 'gray'}}>A 😞😞😞 B</Text>
    </View>
  );
};


export default App;

Before	After

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	20,364,441	-1
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	23,569,574	-7
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 3cb03cb
Branch: main

[facebook-github-bot]

@sammy-SC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@sammy-SC merged this pull request in 01f7ab8.

[github-actions]

This pull request was successfully merged by @j-piasecki in 01f7ab8.

^{When will my fix make it into a release? | How to file a pick request?}