Remove upcasting test in BridgingTest.cpp #37519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46059603 |
Base commit: c396bc7 |
Summary: Pull Request resolved: facebook#37519 While these tests currently happen to pass, actually trying to instantiate `fromJs` fails to compile. I suspect this is attributable to some difference in how `fromJs` is instantiated in evaluated and unevaluated contexts. That is since `supportsFromJs` only instantiates it in an unevaluated context (in a decltype), the rules are presumably different. It is also worth noting that the operator of up-casting JSI types to `jsi::Value` is explicitly deleted in `Converter`, which suggests that the conversion this test is checking for may be intentionally unsupported. For now, since `fromJs` cannot actually be used with the given parameters, delete the test. This unblocks a later diff which changes the constructor of `jsi::Value` such that `std::is_convertible<jsi::Object &, jsi::Value>` is no longer true (the conversion is never allowed, but is currently enforced by `static_assert` ). With that change `supportsFromJs<jsi::Value, jsi::Object>` also becomes false. Changelog: [Internal] Reviewed By: javache, cortinico Differential Revision: D46059603 fbshipit-source-id: a10c0aec36288c509b07b4473c66e4f8688e1c75
neildhar
force-pushed
the
export-D46059603
branch
from
b328579
to
d860eb6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46059603 |
|
This pull request has been merged in 11e80b6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While these tests currently happen to pass, actually trying to
instantiate
fromJsfails to compile. I suspect this is attributableto some difference in how
fromJsis instantiated in evaluated andunevaluated contexts. That is since
supportsFromJsonly instantiatesit in an unevaluated context (in a decltype), the rules are presumably
different.
It is also worth noting that the operator of up-casting JSI types to
jsi::Valueis explicitly deleted inConverter, which suggeststhat the conversion this test is checking for may be intentionally
unsupported.
For now, since
fromJscannot actually be used with the givenparameters, delete the test.
This unblocks a later diff which changes the constructor of
jsi::Valuesuch thatstd::is_convertible<jsi::Object &, jsi::Value>is no longer true (theconversion is never allowed, but is currently enforced by
static_assert). With that changesupportsFromJs<jsi::Value, jsi::Object>also becomes false.Reviewed By: javache, cortinico
Differential Revision: D46059603