Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove upcasting test in BridgingTest.cpp (#37519)
Summary: Pull Request resolved: #37519 While these tests currently happen to pass, actually trying to instantiate `fromJs` fails to compile. I suspect this is attributable to some difference in how `fromJs` is instantiated in evaluated and unevaluated contexts. That is since `supportsFromJs` only instantiates it in an unevaluated context (in a decltype), the rules are presumably different. It is also worth noting that the operator of up-casting JSI types to `jsi::Value` is explicitly deleted in `Converter`, which suggests that the conversion this test is checking for may be intentionally unsupported. For now, since `fromJs` cannot actually be used with the given parameters, delete the test. This unblocks a later diff which changes the constructor of `jsi::Value` such that `std::is_convertible<jsi::Object &, jsi::Value>` is no longer true (the conversion is never allowed, but is currently enforced by `static_assert` ). With that change `supportsFromJs<jsi::Value, jsi::Object>` also becomes false. Changelog: [Internal] Reviewed By: javache, cortinico Differential Revision: D46059603 fbshipit-source-id: 01ede3cadb74ce6a3cd9d5d3ce34b8648fd88de7
- Loading branch information