Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move yargs to a dependency to avoid script failures #35912

Closed
wants to merge 1 commit into from

Conversation

cjhines
Copy link

@cjhines cjhines commented Jan 20, 2023

Summary

yargs depdendency is unavailable on npm ci breaking certain CI builds.

Fixes #35893 (comment)

Changelog: [Internal]

Prevent script failures on certain npm CI setups

Test plan

@facebook-github-bot
Copy link
Contributor

Hi @cjhines!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions
Copy link

github-actions bot commented Jan 20, 2023

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 842aea2

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,461,827 +0
android hermes armeabi-v7a 7,782,417 +0
android hermes x86 8,935,070 +0
android hermes x86_64 8,793,255 +0
android jsc arm64-v8a 9,647,924 +0
android jsc armeabi-v7a 8,382,428 +0
android jsc x86 9,710,143 +0
android jsc x86_64 10,187,277 +0

Base commit: 208f559
Branch: main

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 20, 2023
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cortinico
Copy link
Contributor

/rebase

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 1, 2023
@facebook-github-bot
Copy link
Contributor

@cortinico merged this pull request in 32931b7.

@cortinico
Copy link
Contributor

Apologize this took a bit longer to land @cjhines

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 4e117cb.

@cjhines
Copy link
Author

cjhines commented Mar 2, 2023

How come this was reverted? I'm maybe missing something from your workflow

@cortinico
Copy link
Contributor

This was causing a failure on one of our internal builds and another engineer had to revert it. I'm attempting to land it again, will comment here if this happens

facebook-github-bot pushed a commit that referenced this pull request Mar 2, 2023
Summary:
yargs depdendency is unavailable on npm ci breaking certain CI builds.

Fixes #35893 (comment)

Changelog: [Internal]

Prevent script failures on certain npm CI setups

Pull Request resolved: #35912

Test Plan: waitforsandcastle

Reviewed By: hoxyq

Differential Revision: D43730837

Pulled By: cortinico

fbshipit-source-id: 926182ee8482cd0c7fd183ea3e993a9322680567
@cortinico cortinico removed the Reverted label Mar 2, 2023
@cortinico
Copy link
Contributor

re-merged here 5093e55

rthic23 added a commit to electrode-io/react-native that referenced this pull request Apr 25, 2023
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
yargs depdendency is unavailable on npm ci breaking certain CI builds.

Fixes facebook#35893 (comment)

Changelog: [Internal]

Prevent script failures on certain npm CI setups

Pull Request resolved: facebook#35912

Test Plan: waitforsandcastle

Reviewed By: hoxyq

Differential Revision: D43186870

Pulled By: cortinico

fbshipit-source-id: d7a64daac71b7554780152ed2150094add62ef0d
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
yargs depdendency is unavailable on npm ci breaking certain CI builds.

Fixes facebook#35893 (comment)

Changelog: [Internal]

Prevent script failures on certain npm CI setups

Pull Request resolved: facebook#35912

Test Plan: waitforsandcastle

Reviewed By: hoxyq

Differential Revision: D43730837

Pulled By: cortinico

fbshipit-source-id: 926182ee8482cd0c7fd183ea3e993a9322680567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RN 0.70] Yargs as a devDependency breaks CI builds.
4 participants