[RN 0.70] Yargs as a devDependency breaks CI builds.

[cjhines]

Description

This this merge request yargs is a dev dependency. Is it used in the generate-specs-cli script.

This will cause CI builds using npm ci to fail on this script phase.

Error: Cannot find module 'yargs'

Version

0.70.6

Output of npx react-native info

System:
OS: macOS 12.6.2
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 345.89 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.13.2 - ~/.nvm/versions/node/v16.13.2/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 8.1.2 - ~/.nvm/versions/node/v16.13.2/bin/npm
Watchman: 2023.01.02.00 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.3 - /Users/admin/.rvm/gems/ruby-2.7.5/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.2, iOS 16.2, macOS 13.1, tvOS 16.1, watchOS 9.1
Android SDK:
API Levels: 25, 27, 28, 29, 30, 31, 32, 33
Build Tools: 28.0.3, 29.0.2, 29.0.3, 30.0.1, 30.0.2, 30.0.3, 31.0.0, 33.0.0
System Images: android-23 | Google APIs Intel x86 Atom, android-24 | Google Play Intel x86 Atom, android-27 | Google APIs Intel x86 Atom, android-28 | Google APIs Intel x86 Atom, android-29 | Google APIs Intel x86 Atom, android-29 | Google Play Intel x86 Atom, android-30 | Google APIs Intel x86 Atom, android-30 | Google Play Intel x86 Atom, android-31 | Google APIs Intel x86 Atom_64, android-31 | Google Play Intel x86 Atom_64, android-33 | Google APIs Intel x86 Atom_64
Android NDK: Not Found
IDEs:
Android Studio: 2021.3 AI-213.7172.25.2113.9123335
Xcode: 14.2/14C18 - /usr/bin/xcodebuild
Languages:
Java: 11.0.17 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.1.0 => 18.1.0
react-native: 0.70.6 => 0.70.6
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found

Steps to reproduce

• npm ci
• build development build

Snack, code example, screenshot, or link to a repository

Building on CI with the following configuration will cause an error:

    build_app(
      scheme: "myapp",
      export_method: "development",
      archive_path: "./myapp.xcarchive",
      output_directory: "./development",
      include_bitcode: false,
      suppress_xcode_output: true,
      include_symbols: false,
      silent: false
    )
    ```

[lunaleaps]

Thanks for flagging, want to submit a fix?

[cjhines]

Submitted!