[TextInput] Add numberOfLines and maximumNumberOfLines props on iOS and fix Android implementation #35703

Szymon20000 · 2022-12-22T10:14:59Z

Summary

We want to be able to set height of TextArea/TextInput/EditText components on all platforms in the same way. Was is currently missing on iOS is expressing the height of a component in lines and this pr is supposed to fix it. Additionally in some cases we want to set maximum number of lines a "TextArea" like component can have. Because of Different screen sizes and accessibility settings it's sometimes hard to compute how many lines a current content takes so the purpose of maximumNumberOfLines prop is to simplify that process.

iOS How it was implemented?

On Android the native "TextArea" like component (EditText) exposes setLines method that sets height of the component in lines. However, I wasn't able to find anything similar on iOS. What is a common method for both platforms is setting maximum height in lines. On iOS we can set .maximumNumberOfLines property on TextContainer and similarly on Android we can call setMaxLines() method to limit number of lines. So Adding maximumNumberOfLines is not a problem.

I realised that when we add enough number of newLines in order to implement numberOfLines prop using maximumNumberOfLines functionality and did exactly that. Probably it's possible to get a font size and based on that set exact height but I didn't want to miss any edge cases and adding few newlines doesn't seem to be an overhead at all.
Also probably otherwise we would need to take into account things like space between lines, padding...

Android

It turned out that Android implementation has some issues on Paper and on Fabric the behaviour is shared with TextComponent which limits number of lines instead of setting exact height. So I rewrote the android implementation too.

Fabric

I implemented numberOfLines and maximumNumberOfLines similarly to what I did for paper architecture but it turned out that there is one edge case. Whenever you tapped the enter button it added a new line to the text input. Even though NSTextContainer clearly had set maximumNumberOfLines property. I checked what are differences between paper and Fabric implementation when it comes to using NSTextContainer but I wasn't able to spot any difference. Fonts, spaces, other text attributes were exactly the same for every character. In RN docs I found that TextInput already have support for numberOfLines to I checked if the problem occurs also there. Turned out that problem is there too and moreover it's also in paper architecture. I checked differences on how NSContainer is used and spotted a different order of methods called on NSTextContainer, NSTextStorage and NSLayoutManager. After changing the order the problem is gone everywhere.

Changelog

[ANDROID][FIXED] - fix numberOfLines for TextInput component on Paper
[ANDROID][CHANGED] - change numberOfLines for TextInput component on Fabric so it's consistent with paper implementation and WEB
[ANDROID][ADDED] - add maximumNumberOfLines prop to TextInput
[ISO][ADDED] - add numberOfLines for TextInput component on Paper and Fabric
[IOS][ADDED] - add maximumNumberOfLines prop to TextInput (Paper and Fabric)

Test Plan

test iOS (Paper)
test iOS (Fabric)
test Android (Paper)
test Android (Fabric)

facebook-github-bot · 2022-12-22T10:15:04Z

Hi @Szymon20000!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

analysis-bot · 2022-12-22T10:38:59Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,756,411	-245,054
android	hermes	armeabi-v7a	8,069,058	-186,321
android	hermes	x86	9,248,684	-261,828
android	hermes	x86_64	9,098,523	-257,850
android	jsc	arm64-v8a	9,318,059	-296,472
android	jsc	armeabi-v7a	8,508,012	-233,019
android	jsc	x86	9,381,231	-320,156
android	jsc	x86_64	9,635,243	-312,704

Base commit: 28dfdb2
Branch: main

analysis-bot · 2022-12-22T11:12:36Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 89ef5bd
Branch: main

pull-bot · 2022-12-22T11:24:54Z

PR build artifact for a819cfc is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

facebook-github-bot · 2022-12-22T13:36:52Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

necolas · 2022-12-22T20:29:53Z

Libraries/Components/TextInput/TextInput.js

+   * Sets the number of lines for a `TextInput`. Use it with multiline set to
+   * `true` to be able to fill the lines.
+   */
+  numberOfLines?: ?number,


We intend for this prop to be replaced by the rows prop (see above) as per https://github.com/necolas/discussions-and-proposals/blob/reduce-fragmentation/proposals/0000-reduce-fragmentation.md#textinput-component

Make sense. Does it mean that I should change the name in this pr or are already working on one yourself?

The rows prop (alias for numberOfLines) is already there on L530 ish. It might also make sense to rename (or alias) maximumNumberOfLines to something like maxRows.

Is it android only for now? I haven't seen any logic related to rows on ios.

I only see support for maximumNumberOfLines which is not the same. This pr adds support for numberOfLines so if rows hasn't been implemented yet for ios I can rename numberOfLines in the pr to rows.

@necolas are you interested in this pr? Do you want me to rename the prop to rows?

In the JS layer? Yes, I already mentioned that rows is a thing. See #34488

Ok, then I will adust this pr so it follows the new naming and then ping you here one more time thx.

@necolas I've just renamed it. Sorry for the delay I was super busy with other tasks.

ReactCommon/react/renderer/textlayoutmanager/platform/ios/RCTTextLayoutManager.mm

janicduplessis · 2023-02-14T23:14:43Z

Libraries/Text/Text.js

@@ -228,6 +228,14 @@ const Text: React.AbstractComponent<

  const _hasOnPressOrOnLongPress =
    props.onPress != null || props.onLongPress != null;
+  let numberOfLinesKey = 'numberOfLines';


Why do we need to do this? Can we do it in the native implementation of the fabric view instead of having all these conditions in js?

In Fabric Most of layout logic and props is shared between TextComponent and TextInputComponent on the native side. I didn't wanted to split them and numberOfLines for some reason works differently on Text and TextInput.
ForText is actually sets maximum height while in TextInput it's exact height. I can probably change it on paper architecture to use maximumNumberOfLines on the native side. Let me know if that would be cleaner. :D

Ok, done it this way

janicduplessis · 2023-02-14T23:24:15Z

Libraries/Text/TextInput/Multiline/RCTMultilineTextInputViewManager.m

 #pragma mark - Multiline <TextInput> (aka TextView) specific properties

 RCT_REMAP_VIEW_PROPERTY(dataDetectorTypes, backedTextInputView.dataDetectorTypes, UIDataDetectorTypes)

+RCT_CUSTOM_SHADOW_PROPERTY(maximumNumberOfLines, NSNumber, RCTBaseTextInputShadowView)


I think you can use something like this instead

react-native/Libraries/Text/Text/RCTTextViewManager.m

Line 29 in 11570e7

RCT_REMAP_SHADOW_PROPERTY(numberOfLines, maximumNumberOfLines, NSInteger)

Probably dont need the remap version for the first one since it has same name

janicduplessis · 2023-02-14T23:31:28Z

There are also a few flow errors that will need fixing, you can see on CI.

janicduplessis · 2023-02-14T23:34:22Z

Libraries/Text/TextInput/RCTBaseTextInputShadowView.m

@@ -218,7 +218,16 @@ - (NSAttributedString *)measurableAttributedText

 - (CGSize)sizeThatFitsMinimumSize:(CGSize)minimumSize maximumSize:(CGSize)maximumSize
 {
-  NSAttributedString *attributedText = [self measurableAttributedText];
+  NSMutableAttributedString *attributedText = [[self measurableAttributedText] mutableCopy];


I think it might be worth adding a comment that explains that ios doesnt support setting fixed number of lines and what we are doing.

Same for the fabric part

Added! Let me know if the comments make sense.

Is there a reason for adding the new lines before the text instead of after? Is there any cases where it would affect the width of the input? Also the paper implementation doesn’t need the extra K char to work? I also wonder if there would be a better character to use which has 0 width

Yes, on fabric for some reason I need to add character with non 0 width. Otherwise it wasn't working properly.

I think adding after should work well too.

Szymon20000 · 2023-02-17T14:14:33Z

I think we have differences now between platforms when it comes to how rows/numberOfLines works. (Tested it all in RNTester today)

Android Fabric

Android Fabric rows actually means max number of rows. So it grows when we add line (as long as we don't go over the limit).

iOS Fabric & Paper

rows means that height is fixed and expressed in lines no matter what text we display.

WEB (textarea)

rows means that height is fixed and expressed in lines no matter what text we display.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea#attr-rows

Android Paper

rows means that height is fixed and expressed in lines no matter what text we display.
edit: looks like on paper we set fixed height but it behaves more like minRows :D

@necolas I think it would make sense to have rows and maxRows. What do you think?

matinzd · 2023-03-06T11:16:19Z

ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java

@@ -734,6 +734,11 @@ public void setNumLines(ReactEditText view, int numLines) {
    view.setLines(numLines);
  }

+  @ReactProp(name = ViewProps.MAXIMUM_NUMBER_OF_LINES, defaultInt = 1)


Isn't it better to have -1 (UNSET) as default? It feels a bit weird to me to have 1 max line by default. What happens if someone pass multiline={true}?

Yes, I'm rewriting android part now as I found few issues with current implementation. Hope to finish it today.

Szymon20000 · 2023-03-06T11:51:05Z

I think we have differences now between platforms when it comes to how rows/numberOfLines works. (Tested it all in RNTester today)

Android Fabric

Android Fabric rows actually means max number of rows. So it grows when we add line (as long as we don't go over the limit).

iOS Fabric & Paper

rows means that height is fixed and expressed in lines no matter what text we display.

WEB (textarea)

rows means that height is fixed and expressed in lines no matter what text we display. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea#attr-rows

Android Paper

rows means that height is fixed and expressed in lines no matter what text we display. edit: looks like on paper we set fixed height but it behaves more like minRows :D

@necolas I think it would make sense to have rows and maxRows. What do you think?

@matinzd What do you think about it?

Szymon20000 · 2023-03-07T12:30:44Z

@necolas @matinzd Here is my fix for android part. #36394
I will add it to this pr.

Szymon20000 · 2023-03-08T09:58:55Z

Now both parts should be fine.
I will add test to RNTester and test it all one more time on {'iOS', 'Android'} x {'paper', 'fabric'}
One more thing that's left is updating types.

Szymon20000 · 2023-03-10T10:17:13Z

@matinzd @necolas Could you guys review my changes?
I think it's ready :)

necolas · 2023-03-10T19:42:47Z

Thanks for working through the feedback so far. We'll need someone from the RN team to review the native code and import the PR

janicduplessis

Can you also add examples in RN Tester of the new props?

Overall looks good, if I understand correctly the changes to Text native component are needed because it is also used by TextInput right?

Libraries/Text/TextInput/RCTBaseTextInputShadowView.m

ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManagerMapBuffer.java

janicduplessis · 2023-03-14T18:10:35Z

ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManagerMapBuffer.java

+        : UNSET;
+
+    int lines = layout.getLineCount();
+    if (numberOfLines != UNSET && numberOfLines != 0 && numberOfLines > lines && text.length() > 0) {


Could we share this logic with TextLayoutManager? Or is this file already kind of just a copy of it?

The whole file is a faster copy of TextLayoutManager that uses C++/Java shared buffer instead of using JNI.

...erer/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTTextLayoutManager.mm

janicduplessis · 2023-03-14T18:13:59Z

ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManagerMapBuffer.java

+
+      // for some reason a newline on end causes issues with computing height so we add a character
+      if (text.toString().endsWith("\n")) {
+        ssb.append("A");


Can we append "K\n" like on iOS to avoid having to do this?

ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManagerMapBuffer.java

janicduplessis · 2023-03-14T18:18:55Z

Also could you rebase to see if it fixes CI, failures look unrelated.

Szymon20000 · 2023-03-15T08:26:52Z

Can you also add examples in RN Tester of the new props?

Overall looks good, if I understand correctly the changes to Text native component are needed because it is also used by TextInput right?

The changes are needed because Text native component shares few native objects with TextInput. For instance ParagraphAttributes or TextLayoutManager. However, numberOfLines prop behaves differently on Text and TextInput. In Text Component it actually works like maximumNumberOfLines while in TextInput it means an exact number.

…o graphics folder Differential Revision: D45904748 Original commit changeset: a4e666d7c739 Original Phabricator Diff: D45904748 fbshipit-source-id: c2da28836cb51966854c81d4e380a2abeb742cda

Summary: Chronos Job Instance ID: 1125907889493757 Sandcastle Job Instance ID: 36028797978627335 allow-large-files ignore-conflict-markers opt-out-review Differential Revision: D46270525 fbshipit-source-id: 26beec108aa03c970338fdc4561af24798813acf

Summary: Pull Request resolved: facebook#37572 Currently, RNTester was using a completely custom AppDelegate and not leveraging the RCTAppDelegate we use in the OSS. This resulted in a misalignment between the two setups and duplicated work to test stuff internally furst and then in the OSS, with some more time needed to understand why one setup was working and the other wasn't. With this change, we are aligning the two, bringing RNTester closer to the OSS setup. There are still small differences, but we can iterate over those. ## Changelog: [iOS][Changed] - Make RNTester use RCTAppDelegate Reviewed By: cortinico Differential Revision: D46182888 fbshipit-source-id: 7c55b06de1a317b1f2d4ad0d18a390dc4d3356a4

Summary: Pull Request resolved: facebook#37596 This commit is a backport of this [commit](facebook@32327cc) so that we build the right version of hermes in CI. This also bumps the hermes keys to make sure that we are building it properly from now on. ## Changelog: [Internal] - Fix Hermes versioning and bump hermes workspace keys Reviewed By: cortinico Differential Revision: D46225179 fbshipit-source-id: f00c9d20d37f3bd5689e0742063f98e3bfe373c2

Summary: Pull Request resolved: facebook#37614 changelog: [internal] We do not control what `vImageBoxConvolve_ARGB8888` returns, it may return 0. If it does return 0, we will allocate memory chunk of size 0. Yes, malloc will let you do that. Well, it depends on the implementation, but according to the spec it is legal. The only requirement is to by able to call free on that without crash. If `vImageBoxConvolve_ARGB8888` does return 0 and we allocate memory of size 0. Call to `vImageBoxConvolve_ARGB8888` with tempBuffer of size 0 will lead to a crash. [The documentation](https://developer.apple.com/documentation/accelerate/1515945-vimageboxconvolve_argb8888#discussion) for `vImageBoxConvolve_ARGB8888` and tempBuffer states: > To determine the minimum size for the temporary buffer, the first time you call this function pass the kvImageGetTempBufferSize flag. Pass the same values for all other parameters that you intend to use in for the second call. The function returns the required minimum size, which **should be a positive value**. (A negative returned value indicates an error.) The kvImageGetTempBufferSize flag prevents the function from performing any processing other than to determine the minimum buffer size. I think the keyword word there is "should be a positive value". 0 is not a positive value. Reviewed By: javache, yungsters Differential Revision: D46263204 fbshipit-source-id: baa8fac5b3be6fb5bed02800cd725cc4cf43485a

…targets (facebook#37581) Summary: In Xcode projects with multiple targets, and in particular when targets are for different platforms (e.g. iOS and macOS), Cocoapods may add a suffix to a Pod name like `React-Core`. When this happens, the code in `new_architecture.rb` (which was looking for a pod with exact name `React-Core`) would not add the preprocessor definitions for Fabric as expected. This change fixes this issue. Fixes facebook#37102 . ## Changelog: [iOS] [Fixed] - Fix Fabric issue with React-Core pod when Xcode project has multiple targets Pull Request resolved: facebook#37581 Test Plan: Tested that this change fixes this issue which occurs 100% of the time in React Native TV projects. Reviewed By: dmytrorykun Differential Revision: D46264704 Pulled By: cipolleschi fbshipit-source-id: 8dfc8e342b5a110ef1f028636e01e5c5f2b6e2f0

Summary: This (`greet.yml`) action requires some _changes_ to "repo" settings which are _out of maintainers' controls_. So, instead of wasting compute; let's just delete this action :( 🤗🌏 ## Changelog: [GENERAL] [REMOVED] - [Actions] Remove `greet.yml` action Pull Request resolved: facebook#37587 Test Plan: - Not needed. Reviewed By: cortinico Differential Revision: D46275607 Pulled By: cipolleschi fbshipit-source-id: 80880568cbae1158006445e078e638e4e375cb73

Summary: Pull Request resolved: facebook#37616 Add tests in CircleCI to avoid that changes in Hermes can break the Xcode integration. ## Changelog: [Internal] - Add CI tests to avoid to break the Hermes-Xcode integration Reviewed By: cortinico Differential Revision: D46265656 fbshipit-source-id: 176f1a33fe6944a68fb14b62e5c626fe30d296cc

Summary: Pull Request resolved: facebook#37410 Incremental adoption of new bridgeless API's, where they are semantically equivalent to the old one. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D45736529 fbshipit-source-id: e41f6840e7c329f6051530e53773fae760584842

…nes_rn

Szymon20000 · 2023-06-15T07:13:44Z

@NickGerleman Just added code in js that checks if maximumNumberOfLines prop is define on the native side if not then it uses the previous name.

NickGerleman · 2023-06-15T08:41:07Z

Please split this into different PRs, as per the last comment. This change is too large to review as-is.

Szymon20000 · 2023-06-15T08:42:51Z

Please split this into different PRs, as per the last comment. This change is too large to review as-is.

Sure, Would it be enough to split it into 2 pr android and iOS?

Noitidart · 2023-06-15T13:05:53Z

Please split this into different PRs, as per the last comment. This change is too large to review as-is.

Sure, Would it be enough to split it into 2 pr android and iOS?

Just wanted to keep your morale high by saying thanks for hanging in there @Szymon20000. It's rough going through all the steps after doing so much already. I sincerely appreciate it! This is going to be an amazing feature, I currently use weird workarounds for.

NickGerleman · 2023-06-15T18:53:00Z

Please split this into different PRs, as per the last comment. This change is too large to review as-is.

Sure, Would it be enough to split it into 2 pr android and iOS?

I would recommend as granular as possible. iOS/Android is a good split, especially since there are folks on the React Native team with expertise in one, but not the other.

Another split that is common (depending on how much is shared vs not) is splitting between Paper and Fabric.

Szymon20000 · 2023-06-22T13:03:14Z

@NickGerleman Here is the iOS only pr #38021
This one will become android only once the iOS is merged. I still need to wrap some C++ parts in if-s as it's shared between android and iOS but the pr can already be reviewed on iOS.

...ive/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java

…react/views/textinput/ReactTextInputManager.java Co-authored-by: Jakub Piasecki <jakubpiasecki67@gmail.com>

Szymon20000 · 2023-08-18T16:39:00Z

This pr turned out to be too complex to review it in one go so I extracted iOS part and moved here ->
#38021
closing the pr so it that it doesn't scare away reviewers :)
I will open another pr with android fixes once the iOS one is merged.

Szymon20000 changed the title ~~Add numberOfLines and maximumNumberOfLines props on iOS~~ [TextInput] Add numberOfLines and maximumNumberOfLines props on iOS Dec 22, 2022

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 22, 2022

necolas reviewed Dec 22, 2022

View reviewed changes

roryabraham mentioned this pull request Jan 12, 2023

[HOLD for payment 2023-06-21] [$1000] Chat - Height of edit field is different for mWeb and native app @thesahindia Expensify/App#11694

Closed

roryabraham mentioned this pull request Jan 25, 2023

Add support for numberOfLines and maximumNumberOfLines props on iOS and Android Expensify/react-native#37

Merged

4 tasks

Szymon20000 requested a review from necolas February 1, 2023 12:08

mateoguzmana reviewed Feb 13, 2023

View reviewed changes

ReactCommon/react/renderer/textlayoutmanager/platform/ios/RCTTextLayoutManager.mm Outdated Show resolved Hide resolved

janicduplessis reviewed Feb 14, 2023

View reviewed changes

matinzd reviewed Mar 6, 2023

View reviewed changes

Szymon20000 force-pushed the @szymon/numner_of_lines_rn branch from fb3b94b to 9239ee6 Compare March 8, 2023 09:57

Szymon20000 force-pushed the @szymon/numner_of_lines_rn branch from d1b3ecc to 2b7bda1 Compare March 10, 2023 10:12

Szymon20000 requested review from janicduplessis and removed request for necolas March 10, 2023 10:15

janicduplessis suggested changes Mar 14, 2023

View reviewed changes

android part

c9e11d5

Riccardo Cipolleschi and others added 11 commits June 14, 2023 12:07

Revert D45904748: Move LayoutMetrics and LayoutPrimitives from core t…

f77567d

…o graphics folder Differential Revision: D45904748 Original commit changeset: a4e666d7c739 Original Phabricator Diff: D45904748 fbshipit-source-id: c2da28836cb51966854c81d4e380a2abeb742cda

Merge remote-tracking ranch 'upstream/main' into @szymon/numner_of_li…

5a90e0d

…nes_rn

choose proper numberOfLines prop name based on native config

908eeca

Szymon20000 force-pushed the @szymon/numner_of_lines_rn branch from 1d9ae2c to 908eeca Compare June 15, 2023 07:11

Szymon20000 mentioned this pull request Jun 22, 2023

[iOS][TextInput]Add numberOfLines and maxNumberOfLines props to TextInput on iOS #38021

Closed

Szymon20000 changed the title ~~[TextInput] Add numberOfLines and maximumNumberOfLines props on iOS~~ [TextInput] Add numberOfLines and maximumNumberOfLines props on iOS and fix Android implementation Jun 22, 2023

fabioh8010 mentioned this pull request Jul 5, 2023

Update App to React Native 0.72 version Expensify/App#18507

Merged

57 tasks

j-piasecki reviewed Jul 10, 2023

View reviewed changes

...ive/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java Outdated Show resolved Hide resolved

Update packages/react-native/ReactAndroid/src/main/java/com/facebook/…

bcb467d

…react/views/textinput/ReactTextInputManager.java Co-authored-by: Jakub Piasecki <jakubpiasecki67@gmail.com>

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jul 20, 2023

aimane-chnaif mentioned this pull request Aug 8, 2023

Update App to React Native 0.72.3 version Expensify/App#24224

Merged

57 tasks

AndrewGable mentioned this pull request Aug 18, 2023

Android build times are very slow Expensify/App#25501

Closed

Szymon20000 closed this Aug 18, 2023

fabOnReact mentioned this pull request Sep 14, 2023

Upgrade react native to 0.72.4 Expensify/App#27320

Merged

59 tasks

chrispader mentioned this pull request Nov 16, 2023

[iOS][TextInput]Add numberOfLines and maxNumberOfLines props to TextInput on iOS #41510

Closed

[TextInput] Add numberOfLines and maximumNumberOfLines props on iOS and fix Android implementation #35703

[TextInput] Add numberOfLines and maximumNumberOfLines props on iOS and fix Android implementation #35703

Conversation

Szymon20000 commented Dec 22, 2022 • edited by fabOnReact Loading

Summary

iOS How it was implemented?

Android

Fabric

Changelog

Test Plan

facebook-github-bot commented Dec 22, 2022

Action Required

Process

analysis-bot commented Dec 22, 2022 • edited Loading

analysis-bot commented Dec 22, 2022 • edited Loading

pull-bot commented Dec 22, 2022

facebook-github-bot commented Dec 22, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

necolas Jan 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Szymon20000 Feb 15, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janicduplessis commented Feb 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Szymon20000 commented Feb 17, 2023 • edited Loading

Android Fabric

iOS Fabric & Paper

WEB (textarea)

Android Paper

matinzd Mar 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Szymon20000 commented Mar 6, 2023

Android Fabric

iOS Fabric & Paper

WEB (textarea)

Android Paper

Szymon20000 commented Mar 7, 2023

Szymon20000 commented Mar 8, 2023

Szymon20000 commented Mar 10, 2023

necolas commented Mar 10, 2023

janicduplessis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janicduplessis commented Mar 14, 2023

Szymon20000 commented Mar 15, 2023

Szymon20000 commented Jun 15, 2023

NickGerleman commented Jun 15, 2023

Szymon20000 commented Jun 15, 2023

Noitidart commented Jun 15, 2023 • edited Loading

NickGerleman commented Jun 15, 2023

Szymon20000 commented Jun 22, 2023 • edited Loading

Szymon20000 commented Aug 18, 2023

Szymon20000 commented Dec 22, 2022 •

edited by fabOnReact

Loading

analysis-bot commented Dec 22, 2022 •

edited

Loading

analysis-bot commented Dec 22, 2022 •

edited

Loading

necolas Jan 20, 2023 •

edited

Loading

Szymon20000 Feb 15, 2023 •

edited

Loading

Szymon20000 commented Feb 17, 2023 •

edited

Loading

matinzd Mar 6, 2023 •

edited

Loading

Noitidart commented Jun 15, 2023 •

edited

Loading

Szymon20000 commented Jun 22, 2023 •

edited

Loading