Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actions] Remove greet.yml action #37587

Conversation

Pranav-yadav
Copy link
Contributor

Summary:

This (greet.yml) action requires some changes to "repo" settings which are out of maintainers' controls.
So, instead of wasting compute; let's just delete this action :(
🤗🌏

Changelog:

[GENERAL] [REMOVED] - [Actions] Remove greet.yml action

Test Plan:

  • Not needed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 26, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,740,554 -3
android hermes armeabi-v7a 8,051,622 +1
android hermes x86 9,230,883 +0
android hermes x86_64 9,082,230 +0
android jsc arm64-v8a 9,303,166 +1
android jsc armeabi-v7a 8,491,835 +1
android jsc x86 9,364,569 -1
android jsc x86_64 9,620,022 -3

Base commit: a244209
Branch: main

@Pranav-yadav
Copy link
Contributor Author

Note: I'll be taking a break, since finished with exams and haven't taken one in a while 😅.
I've "Allowed edits by maintainers". So, please feel free to suggest and commit changes as you feel right.
Thanks for reviewing and providing feedback; in advance.

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 50992be.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 30, 2023
Szymon20000 pushed a commit to Szymon20000/react-native that referenced this pull request Jun 14, 2023
Summary:
This (`greet.yml`) action requires some _changes_ to "repo" settings which are _out of maintainers' controls_.
So, instead of wasting compute; let's just delete this action :(
🤗🌏

## Changelog:

[GENERAL] [REMOVED] - [Actions] Remove `greet.yml` action

Pull Request resolved: facebook#37587

Test Plan: - Not needed.

Reviewed By: cortinico

Differential Revision: D46275607

Pulled By: cipolleschi

fbshipit-source-id: 80880568cbae1158006445e078e638e4e375cb73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Type: Removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants