Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defaultProps from SegmentedControlIOS #31804

Closed
wants to merge 4 commits into from
Closed

Remove defaultProps from SegmentedControlIOS #31804

wants to merge 4 commits into from

Conversation

daschaa
Copy link
Contributor

@daschaa daschaa commented Jul 2, 2021

Summary

Issue #31604 . Remove defaultProps from SegmentedControlIOS.

Changelog

[JavaScript] [Changed] - Remove defaultProps from SegmentedControlIOS

Test Plan

Added tests for SegmentedControlIOS pass.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 2, 2021
@daschaa daschaa mentioned this pull request Jul 2, 2021
Closed
@analysis-bot
Copy link

analysis-bot commented Jul 2, 2021 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: ca440b9

@analysis-bot
Copy link

analysis-bot commented Jul 2, 2021 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,120,302 +0
android hermes armeabi-v7a 8,646,331 +0
android hermes x86 9,559,640 +0
android hermes x86_64 9,525,817 +0
android jsc arm64-v8a 10,763,000 +0
android jsc armeabi-v7a 9,680,295 +0
android jsc x86 10,797,746 +0
android jsc x86_64 11,405,430 +0

Base commit: ca440b9

@daschaa daschaa requested a review from lunaleaps July 9, 2021 22:01
@lunaleaps lunaleaps linked an issue Jul 11, 2021 that may be closed by this pull request
Remove defaultProps in SegmentedControlIOS #31604
Closed
@facebook-github-bot
Copy link
Contributor

@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@lunaleaps merged this pull request in fa0518d.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 14, 2021
@lunaleaps
Copy link
Contributor

Thanks @joxw1 for your help!! I modified slightly the prop values from an internal review to make things simpler since we're only using these props in one place. Thank you again!

@yungsters yungsters mentioned this pull request Aug 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunaleaps lunaleaps lunaleaps approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Needs: React Native Team Attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove defaultProps in SegmentedControlIOS
5 participants
@daschaa @analysis-bot @facebook-github-bot @lunaleaps @elicwhite