Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defaultProps in SegmentedControlIOS #31604

Closed
lunaleaps opened this issue May 26, 2021 · 7 comments
Closed

Remove defaultProps in SegmentedControlIOS #31604

lunaleaps opened this issue May 26, 2021 · 7 comments
Assignees
@daschaa
Labels
Component: SegmentedControlIOS Good first issue Interested in collaborating? Take a stab at fixing one of these issues. JavaScript Resolution: Locked This issue was locked by the bot.

Comments

@lunaleaps
Copy link
Contributor

See parent issue #31601

Expected Results

defaultProps are removed in SegmentedControlIOS
@lunaleaps lunaleaps added Good first issue Interested in collaborating? Take a stab at fixing one of these issues. JavaScript Component: SegmentedControlIOS labels May 26, 2021
@lunaleaps lunaleaps mentioned this issue May 26, 2021
Closed
6 tasks
@turker0 turker0 mentioned this issue May 27, 2021
Closed
@kerm1it
Copy link
Contributor

kerm1it commented Jun 1, 2021

Can I take this issue?

@lunaleaps lunaleaps assigned lunaleaps and kerm1it and unassigned lunaleaps Jun 1, 2021
@lunaleaps
Copy link
Contributor Author

@kerm1it assigned! Please set me as a reviewer on your pull request and thank you for your help in making RN better!

Damoness added a commit to Damoness/react-native that referenced this issue Jun 20, 2021
@Damoness
Remove defaultProps in SegmentedControlIOS facebook#31604
2a19c84
@daschaa daschaa mentioned this issue Jul 2, 2021
Closed
@daschaa
Copy link
Contributor

daschaa commented Jul 2, 2021

If it is ok I would like to take this issue 😄 I already created a pull request 🚀

@lunaleaps
Copy link
Contributor Author

@joxw1, I'll let @kerm1it comment on whether they're okay with this change or if they already have work in progress. If I don't hear a response in 2 days (July 9, 2021) then I can assign to you

@kerm1it
Copy link
Contributor

kerm1it commented Jul 8, 2021

I don't recommend to start this before #31644 has not yet been resolved thoroughly.

@lunaleaps
Copy link
Contributor Author

lunaleaps commented Jul 8, 2021 •
edited
Loading

I don't recommend to start this before #31644 has not yet been resolved thoroughly.

Hmm @kerm1it what do you mean? That issue has been resolved.

Edit: For more detail, the issue has been resolved and in addition Picker has been moved out of OSS as part of the lean core effort. See ad0ccac

@kerm1it
Copy link
Contributor

kerm1it commented Jul 9, 2021

OK，you can assign this to @joxw1 , I'm so busy recently.

@lunaleaps lunaleaps assigned daschaa and unassigned kerm1it Jul 9, 2021
@lunaleaps lunaleaps linked a pull request Jul 11, 2021 that will close this issue
Remove defaultProps from SegmentedControlIOS #31804
Closed
facebook-github-bot pushed a commit that referenced this issue Jul 14, 2021
@facebook-github-bot
Remove defaultProps from SegmentedControlIOS (#31804)
fa0518d 
Summary:
Issue #31604 . Remove `defaultProps` from `SegmentedControlIOS`.

## Changelog

[JavaScript] [Changed] - Remove defaultProps from SegmentedControlIOS

Pull Request resolved: #31804

Test Plan: Added tests for `SegmentedControlIOS` pass.

Reviewed By: yungsters

Differential Revision: D29653982

Pulled By: lunaleaps

fbshipit-source-id: ed6e133cc3af629be6cd83be79e402ad1e68b29b
@facebook facebook locked as resolved and limited conversation to collaborators Jul 14, 2022
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@daschaa daschaa

Labels
Component: SegmentedControlIOS Good first issue Interested in collaborating? Take a stab at fixing one of these issues. JavaScript Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove defaultProps from SegmentedControlIOS
4 participants
@lunaleaps @react-native-bot @kerm1it @daschaa