Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump gradle to 6.5 #29043

Closed
wants to merge 1 commit into from
Closed

bump gradle to 6.5 #29043

wants to merge 1 commit into from

Conversation

dulmandakh
Copy link
Contributor

Summary

Bump Gradle to 6.5 or latest version.

Changelog

[Android] [Changed] - bump Gradle to 6.5

Test Plan

RNTester builds and run as expected

@dulmandakh dulmandakh requested a review from mdvacca June 3, 2020 13:56
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Jun 3, 2020
@react-native-bot react-native-bot added the Platform: Android Android applications. label Jun 3, 2020
@analysis-bot
Copy link

analysis-bot commented Jun 3, 2020 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal 809,568 0

Base commit: 976f51a

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,755,647 0
android hermes armeabi-v7a 6,417,883 0
android hermes x86 7,140,908 0
android hermes x86_64 7,031,411 0
android jsc arm64-v8a 8,929,883 0
android jsc armeabi-v7a 8,584,505 0
android jsc x86 8,758,257 0
android jsc x86_64 9,334,382 0

Base commit: 976f51a

@dulmandakh
Copy link
Contributor Author

@mdvacca Windows failure is not related to the change, but JS issue. I'm back 😎

@dulmandakh dulmandakh requested a review from hramos June 4, 2020 04:58
mdvacca
mdvacca reviewed Jul 1, 2020
View reviewed changes
Copy link
Contributor

@mdvacca mdvacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm importing this PR to test and land!

facebook-github-bot
facebook-github-bot reviewed Jul 1, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @dulmandakh in e559aee.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jul 2, 2020
@friederbluemle friederbluemle mentioned this pull request Jul 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@mdvacca mdvacca mdvacca approved these changes

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. Platform: Android Android applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dulmandakh @analysis-bot @react-native-bot @mdvacca @facebook-github-bot