Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Gradle wrapper to 6.5.1 #28914

Closed
wants to merge 1 commit into from
Closed

Upgraded Gradle wrapper to 6.5.1 #28914

wants to merge 1 commit into from

Conversation

SaeedZhiany
Copy link
Contributor

@SaeedZhiany SaeedZhiany commented May 18, 2020

Summary

Welcome to Gradle 6.5.1!

Here are the highlights of this release:

  • Experimental file-system watching
  • Improved version ordering
  • New samples

For more details see https://docs.gradle.org/6.5.1/release-notes.html

Changelog

[Android] [Changed] - Update Gradle Wrapper to 6.5.1

Test Plan

Build project and it should be built successfully.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 18, 2020
@react-native-bot react-native-bot added the Platform: Android Android applications. label May 18, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,781,924 0
android hermes armeabi-v7a 6,446,098 0
android hermes x86 7,169,005 0
android hermes x86_64 7,060,337 0
android jsc arm64-v8a 8,949,819 0
android jsc armeabi-v7a 8,606,414 0
android jsc x86 8,780,044 0
android jsc x86_64 9,356,998 0

Base commit: b72d676

@analysis-bot
Copy link

analysis-bot commented May 18, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: f898bb6

@dulmandakh dulmandakh requested review from mdvacca and hramos May 20, 2020 11:55
@friederbluemle
Copy link
Contributor

Superseded by #29043

Also please note that Gradle 6.4+ unfortunately introduced a whitespace error in the gradlew script (see gradle/gradle#13293 for details) on line 133: https://github.com/facebook/react-native/pull/29043/files#diff-36ffbd2ea7085cf19547193a7faf30c8R133. It's already fixed on Gradle's master branch, and hopefully we can update the Gradle Wrapper again for react-native before the next release, to avoid whitespace errors in the generated files.

@SaeedZhiany
Copy link
Contributor Author

Thanks @friederbluemle.

I'll rebase my PR and upgrade to version 6.5.1. it's even newer than the PR you already mentioned.

@SaeedZhiany SaeedZhiany changed the title Upgraded Gradle wrapper to 6.4.1 Upgraded Gradle wrapper to 6.5.1 Jul 13, 2020
@SaeedZhiany
Copy link
Contributor Author

The failed build seems not related to my change. some internal error causes the problem.

@SaeedZhiany
Copy link
Contributor Author

I close this PR due to a newer version is already merged in the master branch.

@SaeedZhiany SaeedZhiany closed this Nov 2, 2020
@SaeedZhiany SaeedZhiany deleted the Upgrade_Gradle_wrapper branch November 2, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: Android Android applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants