-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address @octokit/rest deprecation warnings #28050
Conversation
RNTester (Android/hermes/arm64-v8a): 3276800 bytes |
@hramos It looks like |
It won’t run if test_js fails. I’m looking at that failure today. |
BTW, #28048 fixes test_js, next up I need to see if the test_js_e2e failure already exists in master or not. I'm following up on this later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @tido64 in de8fcfb. When will my fix make it into a release? | Upcoming Releases |
Summary: Addresses deprecation warnings from `octokit/rest`. This is a follow up to facebook#28019. ## Changelog [Internal] [Fixed] - Address deprecation warnings from `octokit/rest` Pull Request resolved: facebook#28050 Test Plan: PRs should still get app bundle sizes report, but the warnings in the build logs should be gone. Reviewed By: cpojer Differential Revision: D20008805 Pulled By: hramos fbshipit-source-id: 891d14fd9d55f217194a095d2736494416dacda2
Summary
Addresses deprecation warnings from
@octokit/rest
. This is a follow up to #28019.Changelog
[Internal] [Fixed] - Address deprecation warnings from
@octokit/rest
Test Plan
PRs should still get app bundle sizes report, but the warnings in the build logs should be gone.