-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report size of app bundles on PRs #28019
Conversation
bf989b5
to
64521fe
Compare
RNTester.app (iOS): 9846784 bytes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Making a slight adjustment - moving octokit/rest from a devDependency in the root package.json, to the bots/package.json file should work as well. It also keeps us from having to add octokit to our internal yarn offline mirror (which is based off the root package.json). I couldn't update bots/package.json in your PR so the latest CI run will likely fail, but you may safely ignore that. I already made these changes internally. |
Summary: Report size of app bundles on PRs. See [React Native Benchmark Suite](react-native-community/discussions-and-proposals#186) for further discussion. ## Changelog [Internal] [Added] - Report size of app bundles on PRs Pull Request resolved: facebook#28019 Test Plan: PRs should start seeing comments from a bot with app bundle sizes, given that they got built successfully. Differential Revision: D19859187 Pulled By: hramos fbshipit-source-id: 48ba25903356b219135716f989a4a3c05140abfb
@hramos Thanks for reviewing this!
Since you've bumped the version number, should we also fix the deprecation warnings? |
Summary: Pull Request resolved: facebook#28041 Report size of app bundles on PRs. See [React Native Benchmark Suite](react-native-community/discussions-and-proposals#186) for further discussion. ## Changelog [Internal] [Added] - Report size of app bundles on PRs Pull Request resolved: facebook#28019 Test Plan: PRs should start seeing comments from a bot with app bundle sizes, given that they got built successfully. Reviewed By: cpojer Differential Revision: D19859187 Pulled By: hramos fbshipit-source-id: 0eb510287ba2001895d66d038fc1e7b8a722d9a8
Merged! Yes, we should fix the deprecated warnings. I also filed #28043 as a related item that came up while testing this. |
Summary: Addresses deprecation warnings from `octokit/rest`. This is a follow up to #28019. ## Changelog [Internal] [Fixed] - Address deprecation warnings from `octokit/rest` Pull Request resolved: #28050 Test Plan: PRs should still get app bundle sizes report, but the warnings in the build logs should be gone. Reviewed By: cpojer Differential Revision: D20008805 Pulled By: hramos fbshipit-source-id: 891d14fd9d55f217194a095d2736494416dacda2
test |
4 similar comments
test |
test |
test |
test |
Summary: Pull Request resolved: facebook#28041 Report size of app bundles on PRs. See [React Native Benchmark Suite](react-native-community/discussions-and-proposals#186) for further discussion. ## Changelog [Internal] [Added] - Report size of app bundles on PRs Pull Request resolved: facebook#28019 Test Plan: PRs should start seeing comments from a bot with app bundle sizes, given that they got built successfully. Reviewed By: cpojer Differential Revision: D19859187 Pulled By: hramos fbshipit-source-id: 3920dc60e6fd073928388e6ae52fc2ba1bc745ac
Summary: Addresses deprecation warnings from `octokit/rest`. This is a follow up to facebook#28019. ## Changelog [Internal] [Fixed] - Address deprecation warnings from `octokit/rest` Pull Request resolved: facebook#28050 Test Plan: PRs should still get app bundle sizes report, but the warnings in the build logs should be gone. Reviewed By: cpojer Differential Revision: D20008805 Pulled By: hramos fbshipit-source-id: 891d14fd9d55f217194a095d2736494416dacda2
Summary
Report size of app bundles on PRs. See React Native Benchmark Suite for further discussion.
Changelog
[Internal] [Added] - Report size of app bundles on PRs
Test Plan
PRs should start seeing comments from a bot with app bundle sizes, given that they got built successfully.