Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline view examples to RNTester #24814

Closed
wants to merge 4 commits into from

Commits on May 9, 2019

  1. Revert "Revert inline view example"

    This reverts commit b87336b.
    
    Bring back the inline view example
    Adam Comella committed May 9, 2019
    Configuration menu
    Copy the full SHA
    f7888c9 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2019

  1. Add inline view examples to RNTester

    I brought back examples from facebook@0366349. "Inline views" works on iOS and Android. The other two only work on iOS. See the comment for details.
    
    I also added some new inline view examples in TextInlineView.js. "Basic" works well. The others do not:
      - ClippedByText
        - iOS: The image/view do not get wrapped to the next line
        - Android: The view gets wrapped to the next line but isn't clipped vertically. The image appears to be positioned too low.
      - ChangeImageSize/ChangeViewSize:
        - iOS: First update works. Subsequent updates don't get rendered.
        - Android: No updates get rendered.
      - ChangeInnerViewSize:
        - iOS: First update works. Second update CRASHES the app.
        - Android: No updates get rendered.
    Adam Comella committed May 11, 2019
    Configuration menu
    Copy the full SHA
    b2672f5 View commit details
    Browse the repository at this point in the history
  2. Run prettier

    Adam Comella committed May 11, 2019
    Configuration menu
    Copy the full SHA
    1acae2f View commit details
    Browse the repository at this point in the history
  3. Switch from Haste to standard import

    Co-Authored-By: James Ide <ide@users.noreply.github.com>
    rigdern and ide authored May 11, 2019
    Configuration menu
    Copy the full SHA
    7eef71c View commit details
    Browse the repository at this point in the history