Add inline view examples to RNTester #24814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 9, 2019 16:31
This reverts commit b87336b. Bring back the inline view example
I brought back examples from facebook@0366349. "Inline views" works on iOS and Android. The other two only work on iOS. See the comment for details. I also added some new inline view examples in TextInlineView.js. "Basic" works well. The others do not: - ClippedByText - iOS: The image/view do not get wrapped to the next line - Android: The view gets wrapped to the next line but isn't clipped vertically. The image appears to be positioned too low. - ChangeImageSize/ChangeViewSize: - iOS: First update works. Subsequent updates don't get rendered. - Android: No updates get rendered. - ChangeInnerViewSize: - iOS: First update works. Second update CRASHES the app. - Android: No updates get rendered.
facebook-github-bot
added
CLA Signed
react-native-bot
added
the
Type: Enhancement
ide
reviewed
May 11, 2019
Co-Authored-By: James Ide <ide@users.noreply.github.com>
cpojer
approved these changes
May 13, 2019
facebook-github-bot
approved these changes
May 13, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @rigdern in a2a03bc. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that inline views are supported on iOS and Android, we can add some examples to RNTester. I brought back examples from 0366349.
I also added some new inline view examples in TextInlineView.js. Note that some examples are only supported on iOS because they rely on the inline view being able to size to content. Android's implementation requires that a width and height be specified on the inline view.
Here are the known bugs illustrated by these examples:
Changelog
[Internal] [Added] - Added inline view examples to RNTester
Test Plan
Verified the new examples in RNTester on iOS and Android.
iOS: New Examples
Android: New Examples
Adam Comella
Microsoft Corp.