Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flow-strict] Flow strict in DatePickerAndroid.android.js, DatePickerAndroid.ios.js #22106

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,38 @@
* LICENSE file in the root directory of this source tree.
*
* @format
* @flow
* @flow strict-local
*/

'use strict';

const DatePickerModule = require('NativeModules').DatePickerAndroid;

type Options = $ReadOnly<{|
date?: ?(Date | number),
minDate?: ?(Date | number),
maxDate?: ?(Date | number),
mode?: ?('calender' | 'spinner' | 'default'),
|}>;

type DatePickerOpenAction =
| {|
action: 'dateSetAction',
year: number,
month: number,
day: number,
|}
| {|
action: 'dismissedAction',
year: typeof undefined,
month: typeof undefined,
day: typeof undefined,
|};

/**
* Convert a Date to a timestamp.
*/
function _toMillis(options: Object, key: string) {
function _toMillis(options: Options, key: string) {
const dateVal = options[key];
// Is it a Date object?
if (typeof dateVal === 'object' && typeof dateVal.getMonth === 'function') {
Expand Down Expand Up @@ -65,7 +86,7 @@ class DatePickerAndroid {
* Note the native date picker dialog has some UI glitches on Android 4 and lower
* when using the `minDate` and `maxDate` options.
*/
static async open(options: Object): Promise<Object> {
static async open(options: Options): Promise<DatePickerOpenAction> {
const optionsMs = options;
if (optionsMs) {
_toMillis(options, 'date');
Expand All @@ -78,15 +99,11 @@ class DatePickerAndroid {
/**
* A date has been selected.
*/
static get dateSetAction() {
return 'dateSetAction';
}
static dateSetAction = 'dateSetAction';
/**
* The dialog has been dismissed.
*/
static get dismissedAction() {
return 'dismissedAction';
}
static dismissedAction = 'dismissedAction';
}

module.exports = DatePickerAndroid;
11 changes: 9 additions & 2 deletions Libraries/Components/DatePickerAndroid/DatePickerAndroid.ios.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,20 @@
* LICENSE file in the root directory of this source tree.
*
* @format
* @flow
* @flow strict-local
*/

'use strict';

type Options = $ReadOnly<{|
date?: ?(Date | number),
minDate?: ?(Date | number),
maxDate?: ?(Date | number),
mode?: ?('calender' | 'spinner' | 'default'),
|}>;

const DatePickerAndroid = {
async open(options: Object): Promise<Object> {
async open(options: Options): Promise<void> {
return Promise.reject({
message: 'DatePickerAndroid is not supported on this platform.',
});
Expand Down